Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Qt 5.12 and 5.14 #201765

Closed
22 of 31 tasks
K900 opened this issue Nov 18, 2022 · 14 comments · Fixed by #202661
Closed
22 of 31 tasks

Drop Qt 5.12 and 5.14 #201765

K900 opened this issue Nov 18, 2022 · 14 comments · Fixed by #202661
Assignees
Labels
6.topic: old-versions Tickets pertaining to ongoing support of outdated versions of packages 6.topic: qt/kde 8.has: clean-up

Comments

@K900
Copy link
Contributor

K900 commented Nov 18, 2022

We have 32 packages that depend on pre-5.15 Qt. Those are (as determined by rg '\s+(.*) = libsForQt51[24]\.callPackage' --no-line-number -o -r '$1'):

The old Qt versions are a big maintenance burden, as evidenced by them breaking yet again with #200872, and we should really get rid of them.

Ping @NixOS/qt-kde

Also general ping to all the maintainers of affected packages:

@K900 K900 added 6.topic: qt/kde 6.topic: old-versions Tickets pertaining to ongoing support of outdated versions of packages labels Nov 18, 2022
@K900 K900 self-assigned this Nov 18, 2022
@vbgl
Copy link
Contributor

vbgl commented Nov 18, 2022

smtube: #201770

@suhr suhr mentioned this issue Nov 18, 2022
13 tasks
@bjornfor
Copy link
Contributor

Re: pulseview. I tried updating to default qt version and it failed to build. Then I pinged upstream: https://sourceforge.net/p/sigrok/mailman/message/37736944/.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Nov 18, 2022

Antimony is on very low maintenance but I should be able to fix it and get a patch merged, not so soon though. Do you intend to drop Qt <5.15 for 22.11 or a later release?

@K900
Copy link
Contributor Author

K900 commented Nov 18, 2022

I think it's too late for 22.11, but I want to do it early in the 23.05 cycle.

@Maxdamantus
Copy link
Contributor

polyphone: #201974

@flokli
Copy link
Contributor

flokli commented Nov 20, 2022

There seems to already be an issue about that: #53079

Can we check if something important is still missing from there?

@K900
Copy link
Contributor Author

K900 commented Nov 20, 2022

That issue is about deprecating the QtWebKit module from all Qt versions (5.15 included). This one is about deprecating the older versions entirely. There's some overlap, but it's not all.

@LunNova
Copy link
Member

LunNova commented Nov 20, 2022

notepadqq: #202075

@K900
Copy link
Contributor Author

K900 commented Nov 25, 2022

Tried updating mythtv, v32 should be buildable with Qt 5.15, but it fails to link its own vendored ffmpeg and I don't want to dig into 15k lines of bash that are their build system. WIP patch if anyone wants to continue: https://termbin.com/e1o6

@K900
Copy link
Contributor Author

K900 commented Nov 26, 2022

Doing a quick audit on the remaining packages that don't build with 5.15:

Package Dead Notes
boomerang very
fontmatrix basically
foxitreader ? can't fetch the source, package hasn't been updated for over a year
kexi basically
olive-editor ? upstream is active, but last numbered release in 2019 - update to unstable?
pulseview ? deadness of upstream needs confirmation
quiterss yes builds on 5.15 but segfaults on startup
swift-im very
tony very

@K900
Copy link
Contributor Author

K900 commented Nov 26, 2022

I think it might be worth trying to save graphia, mythtv and xygrib, and the rest should be good to drop.

@lilyinstarlight
Copy link
Member

lilyinstarlight commented Nov 26, 2022

@K900, there is an open PR for the mythtv update already that seems to work with a few modifications from your patch above: #197930

Edit: I've opened #203145

@K900
Copy link
Contributor Author

K900 commented Nov 27, 2022

Awesome, I must have missed it. So, should we get all of this merged and rip off the bandaid?

@K900
Copy link
Contributor Author

K900 commented Nov 28, 2022

#202661 should be good to go. I'm giving it a few days so any affected packages can get fixed, but I want to merge it by the end of the week at the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: old-versions Tickets pertaining to ongoing support of outdated versions of packages 6.topic: qt/kde 8.has: clean-up
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants