Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-1452: Changed vcenter MaxItems to be 3 for TechPreview. #1842

Merged
merged 3 commits into from May 8, 2024
Merged

SPLAT-1452: Changed vcenter MaxItems to be 3 for TechPreview. #1842

merged 3 commits into from May 8, 2024

Conversation

vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Apr 1, 2024 •
edited

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2024 •
edited by openshift-ci bot

@vr4manta: This pull request references SPLAT-1452 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

SPLAT-1452

CHANGES

  • Created new VSphereMultiVCenters feature gate
  • Generated new CRDs with max vcenter = 3 when TechPreview
  • Default FG remains 1 max vcenter

DEPENDENCIES

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 1, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

Hello @vr4manta! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 1, 2024
@vr4manta vr4manta mentioned this pull request Apr 1, 2024
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 1, 2024 •
edited by openshift-ci bot

@vr4manta: This pull request references SPLAT-1452 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

SPLAT-1452

Changes

  • Created new VSphereMultiVCenters feature gate
  • Generated new CRDs with max vcenter = 3 when TechPreview
  • Default FG remains 1 max vcenter

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

This was referenced Apr 1, 2024
Draft
Draft
Draft
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 20, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2024
@vr4manta vr4manta force-pushed the SPLAT-1452 branch 2 times, most recently from e26c54f to ebbded6 Compare April 23, 2024 13:09
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024
@vr4manta vr4manta force-pushed the SPLAT-1452 branch 4 times, most recently from cbbd567 to 5cbb0c6 Compare April 30, 2024 10:55
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 30, 2024
@vr4manta vr4manta force-pushed the SPLAT-1452 branch 8 times, most recently from 4011c87 to 00387ac Compare May 1, 2024 17:43
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
JoelSpeed
JoelSpeed reviewed May 7, 2024
View reviewed changes
...ation/v1/tests/controllerconfigs.machineconfiguration.openshift.io/VSphereMultiVCenters.yaml Outdated
@@ -0,0 +1,103 @@
apiVersion: apiextensions.k8s.io/v1 # Hack because controller-gen complains if we don't have this
name: "Shamefully missing"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this more appropriate to the feature/types, see how we format this for other tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test file confused me. For some reason the tooling said I had to add it when I didn't make a direct change to it. I copied the same test as VSphereControlPlaneMachineSet.yaml. In fact, reviewing all the other tests for controllerconfigs, they are the same copy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the test name the new convention. We'll need to update the rest of the tests in that directory at a later time.

...ation/v1/tests/controllerconfigs.machineconfiguration.openshift.io/VSphereMultiVCenters.yaml Outdated
name: pull-secret
namespace: openshift-config
releaseImage: ""
rootCAData: Y2VydGlmaWNhdGUK
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, missing a new line at the end here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry. I copied from other files in the same directory. I'll add the new line.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
JoelSpeed
JoelSpeed reviewed May 7, 2024
View reviewed changes
Copy link
Contributor

@JoelSpeed JoelSpeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 7, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD d591253 and 2 for PR HEAD a1c8128 in total

@JoelSpeed
Copy link
Contributor

/override ci/prow/verify-crd-schema

Pre-existing failures being added to the new FeatureGated version of the file

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2024

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to this:

/override ci/prow/verify-crd-schema

Pre-existing failures being added to the new FeatureGated version of the file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 62b890e and 1 for PR HEAD a1c8128 in total

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2024
@rvanderp3
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, JoelSpeed, rvanderp3, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 62b890e and 2 for PR HEAD 3a0f16f in total

@JoelSpeed
Copy link
Contributor

/override ci/prow/verify-crd-schema

Pre-existing failures, see previous

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to this:

/override ci/prow/verify-crd-schema

Pre-existing failures, see previous

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 8, 2024

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 95e2292 into openshift:master May 8, 2024
18 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.16.0-202405081611.p0.g95e2292.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

@vr4manta vr4manta mentioned this pull request May 10, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcpowermac jcpowermac jcpowermac left review comments

@JoelSpeed JoelSpeed JoelSpeed left review comments

@deads2k deads2k Awaiting requested review from deads2k

@jkyros jkyros Awaiting requested review from jkyros

Assignees

@jcpowermac jcpowermac

@JoelSpeed JoelSpeed

@rvanderp3 rvanderp3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vr4manta @openshift-ci-robot @jcpowermac @JoelSpeed @rvanderp3 @openshift-bot @openshift-merge-robot