Skip to content

Commit

Permalink
Changed vcenter MaxItems to be 3 for TechPreview.
Browse files Browse the repository at this point in the history
  • Loading branch information
vr4manta committed Apr 22, 2024
1 parent a8b3ba9 commit e26c54f
Show file tree
Hide file tree
Showing 22 changed files with 4,144 additions and 12 deletions.
7 changes: 7 additions & 0 deletions config/v1/feature_gates.go
Expand Up @@ -338,6 +338,13 @@ var (
enableIn(Default, DevPreviewNoUpgrade, TechPreviewNoUpgrade).
mustRegister()

FeatureGateVSphereMultiVCenters = newFeatureGate("VSphereMultiVCenters").
reportProblemsToJiraComponent("splat").
contactPerson("vr4manta").
productScope(ocpSpecific).
enableIn(TechPreviewNoUpgrade).
mustRegister()

FeatureGateVSphereStaticIPs = newFeatureGate("VSphereStaticIPs").
reportProblemsToJiraComponent("splat").
contactPerson("rvanderp3").
Expand Down
3 changes: 2 additions & 1 deletion config/v1/types_infrastructure.go
Expand Up @@ -1333,8 +1333,9 @@ type VSpherePlatformSpec struct {
// ---
// + If VCenters is not defined use the existing cloud-config configmap defined
// + in openshift-config.
// +kubebuilder:validation:MaxItems=1
// +kubebuilder:validation:MinItems=0
// +openshift:validation:FeatureGateAwareMaxItems:featureGate=VSphereMultiVCenters,featureGateEnabled=false,maxItems=1
// +openshift:validation:FeatureGateAwareMaxItems:featureGate=VSphereMultiVCenters,featureGateEnabled=true,maxItems=3
// +listType=atomic
// +optional
VCenters []VSpherePlatformVCenterSpec `json:"vcenters,omitempty"`
Expand Down
Expand Up @@ -892,7 +892,7 @@ spec:
- datacenters
- server
type: object
maxItems: 1
maxItems: 3
minItems: 0
type: array
x-kubernetes-list-type: atomic
Expand Down
Expand Up @@ -892,7 +892,7 @@ spec:
- datacenters
- server
type: object
maxItems: 1
maxItems: 3
minItems: 0
type: array
x-kubernetes-list-type: atomic
Expand Down
1 change: 1 addition & 0 deletions config/v1/zz_generated.featuregated-crd-manifests.yaml
Expand Up @@ -303,6 +303,7 @@ infrastructures.config.openshift.io:
- GCPClusterHostedDNS
- GCPLabelsTags
- VSphereControlPlaneMachineSet
- VSphereMultiVCenters
FilenameOperatorName: config-operator
FilenameOperatorOrdering: "01"
FilenameRunLevel: "0000_10"
Expand Down

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions features.md
Expand Up @@ -41,6 +41,7 @@
| TranslateStreamCloseWebsocketRequests| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| UpgradeStatus| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| VSphereDriverConfiguration| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| VSphereMultiVCenters| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ValidatingAdmissionPolicy| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| VolumeGroupSnapshot| | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
| ExternalOIDC| <span style="background-color: #519450">Enabled</span> | | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> | <span style="background-color: #519450">Enabled</span> |
Expand Down
Expand Up @@ -1185,7 +1185,7 @@ spec:
- datacenters
- server
type: object
maxItems: 1
maxItems: 3
minItems: 0
type: array
x-kubernetes-list-type: atomic
Expand Down
Expand Up @@ -1185,7 +1185,7 @@ spec:
- datacenters
- server
type: object
maxItems: 1
maxItems: 3
minItems: 0
type: array
x-kubernetes-list-type: atomic
Expand Down
Expand Up @@ -32,6 +32,7 @@ controllerconfigs.machineconfiguration.openshift.io:
- GCPClusterHostedDNS
- GCPLabelsTags
- VSphereControlPlaneMachineSet
- VSphereMultiVCenters
FilenameOperatorName: machine-config
FilenameOperatorOrdering: "01"
FilenameRunLevel: "0000_80"
Expand Down

0 comments on commit e26c54f

Please sign in to comment.