Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-1553: Added multi vCenter support for capi installer. #8221

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

SPLAT-1553: Added multi vCenter support for capi installer. #8221

wants to merge 3 commits into from

Conversation

vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Apr 1, 2024

SPLAT-1553

Changes

  • Added logic to create VM components on multiple vCenters

Dependencies

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 1, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 1, 2024 •
edited by openshift-ci bot

@vr4manta: This pull request references SPLAT-1553 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

SPLAT-1553

Changes

  • Added logic to create VM components on multiple vCenters

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 11, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 16, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 18, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jhixson74 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024
@vr4manta vr4manta mentioned this pull request May 6, 2024
Merged
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 7, 2024
@vr4manta vr4manta force-pushed the SPLAT-1553 branch 3 times, most recently from d323f77 to 83d2537 Compare May 8, 2024 14:04
@vr4manta vr4manta mentioned this pull request May 9, 2024
Draft
@vr4manta
Copy link
Contributor Author

vr4manta commented May 9, 2024

/payload-job-with-prs periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn #8221 openshift/vmware-vsphere-csi-driver#117 openshift/vmware-vsphere-csi-driver-operator#228 openshift/cluster-storage-operator#465 openshift/machine-config-operator#4298

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

@vr4manta: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@vr4manta
Copy link
Contributor Author

vr4manta commented May 9, 2024

/payload-job-with-prs periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn openshift/vmware-vsphere-csi-driver#117 openshift/vmware-vsphere-csi-driver-operator#228 openshift/cluster-storage-operator#465 openshift/machine-config-operator#4298

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

@vr4manta: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@vr4manta
Copy link
Contributor Author

vr4manta commented May 9, 2024

/payload-job-with-prs periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn openshift/vmware-vsphere-csi-driver#117 openshift/vmware-vsphere-csi-driver-operator#228 openshift/cluster-storage-operator#465 openshift/machine-config-operator#4298

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2b3196f0-0dfa-11ef-91c8-1b3bdde4af13-0

This was referenced May 9, 2024
Merged
Draft
This was referenced May 9, 2024
Draft
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2024
@vr4manta vr4manta force-pushed the SPLAT-1553 branch 2 times, most recently from c2d81d2 to a9eb992 Compare May 16, 2024 16:24
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 16, 2024
@vr4manta
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn openshift/vmware-vsphere-csi-driver#117 openshift/vmware-vsphere-csi-driver-operator#228 openshift/cluster-storage-operator#465 openshift/machine-config-operator#4298 openshift/cluster-config-operator#418

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3dc68ee0-13a1-11ef-8e81-89f345da5761-0

@openshift-ci openshift-ci bot mentioned this pull request May 16, 2024
Merged
@vr4manta
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn openshift/vmware-vsphere-csi-driver#117 openshift/vmware-vsphere-csi-driver-operator#228 openshift/cluster-storage-operator#465 openshift/machine-config-operator#4298 openshift/machine-api-operator#1241

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 17, 2024

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/652f0350-144a-11ef-979c-c7c5c682dc9f-0

@openshift-ci openshift-ci bot mentioned this pull request May 17, 2024
Open
@vr4manta
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn openshift/vmware-vsphere-csi-driver#117 openshift/vmware-vsphere-csi-driver-operator#228 openshift/cluster-storage-operator#465 openshift/machine-config-operator#4298 openshift/machine-api-operator#1241

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 17, 2024

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3383e5f0-1486-11ef-8537-9fe6a0f164a0-0

@vr4manta
Copy link
Contributor Author

/payload-job-with-prs periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn openshift/vmware-vsphere-csi-driver#117 openshift/vmware-vsphere-csi-driver-operator#228 openshift/machine-api-operator#1241

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 22, 2024

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/95311f20-1841-11ef-9b01-9722b6bcac78-0

@vr4manta
Copy link
Contributor Author

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 22, 2024

@vr4manta: The following commands are available to trigger required jobs:

  • /test agent-integration-tests
  • /test altinfra-images
  • /test altinfra-periodics-images
  • /test aro-unit
  • /test e2e-agent-compact-ipv4
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-edge-zones-manifest-validation
  • /test e2e-aws-ovn-upi
  • /test e2e-azure-ovn
  • /test e2e-azure-ovn-upi
  • /test e2e-gcp-ovn
  • /test e2e-gcp-ovn-upi
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack-ovn
  • /test e2e-vsphere-ovn
  • /test e2e-vsphere-upi
  • /test gofmt
  • /test golint
  • /test govet
  • /test images
  • /test okd-images
  • /test okd-unit
  • /test okd-verify-codegen
  • /test openstack-manifests
  • /test shellcheck
  • /test terraform-images
  • /test terraform-verify-vendor
  • /test tf-lint
  • /test unit
  • /test verify-codegen
  • /test verify-vendor
  • /test yaml-lint

The following commands are available to trigger optional jobs:

  • /test altinfra-e2e-aws-custom-security-groups
  • /test altinfra-e2e-aws-ovn
  • /test altinfra-e2e-aws-ovn-fips
  • /test altinfra-e2e-aws-ovn-imdsv2
  • /test altinfra-e2e-aws-ovn-localzones
  • /test altinfra-e2e-aws-ovn-proxy
  • /test altinfra-e2e-aws-ovn-public-ipv4-pool
  • /test altinfra-e2e-aws-ovn-shared-vpc
  • /test altinfra-e2e-aws-ovn-shared-vpc-local-zones
  • /test altinfra-e2e-aws-ovn-shared-vpc-wavelength-zones
  • /test altinfra-e2e-aws-ovn-single-node
  • /test altinfra-e2e-aws-ovn-wavelengthzones
  • /test altinfra-e2e-azure-capi-ovn
  • /test altinfra-e2e-gcp-capi-ovn
  • /test altinfra-e2e-gcp-ovn-byo-network-capi
  • /test altinfra-e2e-gcp-ovn-secureboot-capi
  • /test altinfra-e2e-gcp-ovn-xpn-capi
  • /test altinfra-e2e-ibmcloud-capi-ovn
  • /test altinfra-e2e-nutanix-capi-ovn
  • /test altinfra-e2e-openstack-capi-ccpmso
  • /test altinfra-e2e-openstack-capi-ccpmso-zone
  • /test altinfra-e2e-openstack-capi-dualstack
  • /test altinfra-e2e-openstack-capi-dualstack-upi
  • /test altinfra-e2e-openstack-capi-dualstack-v6primary
  • /test altinfra-e2e-openstack-capi-externallb
  • /test altinfra-e2e-openstack-capi-nfv-intel
  • /test altinfra-e2e-openstack-capi-ovn
  • /test altinfra-e2e-openstack-capi-proxy
  • /test altinfra-e2e-powervs-capi-ovn
  • /test altinfra-e2e-vsphere-capi-multi-vcenter-ovn
  • /test altinfra-e2e-vsphere-capi-ovn
  • /test altinfra-e2e-vsphere-capi-static-ovn
  • /test altinfra-e2e-vsphere-capi-zones
  • /test altinfra-openstack-capi-manifests
  • /test azure-ovn-marketplace-images
  • /test e2e-agent-compact-ipv4-appliance
  • /test e2e-agent-compact-ipv4-appliance-diskimage
  • /test e2e-agent-compact-ipv4-none-platform
  • /test e2e-agent-ha-dualstack
  • /test e2e-agent-sno-ipv4-pxe
  • /test e2e-agent-sno-ipv6
  • /test e2e-aws-custom-security-groups
  • /test e2e-aws-overlay-mtu-ovn-1200
  • /test e2e-aws-ovn-edge-zones
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-imdsv2
  • /test e2e-aws-ovn-proxy
  • /test e2e-aws-ovn-public-subnets
  • /test e2e-aws-ovn-shared-vpc
  • /test e2e-aws-ovn-shared-vpc-edge-zones
  • /test e2e-aws-ovn-single-node
  • /test e2e-aws-ovn-upgrade
  • /test e2e-aws-ovn-workers-rhel8
  • /test e2e-aws-upi-proxy
  • /test e2e-azure-ovn-resourcegroup
  • /test e2e-azure-ovn-shared-vpc
  • /test e2e-azurestack
  • /test e2e-azurestack-upi
  • /test e2e-crc
  • /test e2e-gcp-ovn-byo-vpc
  • /test e2e-gcp-ovn-xpn
  • /test e2e-gcp-secureboot
  • /test e2e-gcp-upgrade
  • /test e2e-gcp-upi-xpn
  • /test e2e-ibmcloud-ovn
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi-ovn
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-swapped-hosts
  • /test e2e-metal-ipi-ovn-virtualmedia
  • /test e2e-metal-single-node-live-iso
  • /test e2e-nutanix-ovn
  • /test e2e-openstack-ccpmso
  • /test e2e-openstack-ccpmso-zone
  • /test e2e-openstack-dualstack
  • /test e2e-openstack-dualstack-upi
  • /test e2e-openstack-externallb
  • /test e2e-openstack-nfv-intel
  • /test e2e-openstack-proxy
  • /test e2e-vsphere-static-ovn
  • /test e2e-vsphere-upi-zones
  • /test e2e-vsphere-zones
  • /test e2e-vsphere-zones-techpreview
  • /test okd-e2e-agent-compact-ipv4
  • /test okd-e2e-agent-ha-dualstack
  • /test okd-e2e-agent-sno-ipv6
  • /test okd-e2e-aws-ovn
  • /test okd-e2e-aws-ovn-upgrade
  • /test okd-e2e-gcp
  • /test okd-e2e-gcp-ovn-upgrade
  • /test okd-e2e-vsphere
  • /test okd-scos-images
  • /test tf-fmt

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-installer-master-altinfra-images
  • pull-ci-openshift-installer-master-altinfra-periodics-images
  • pull-ci-openshift-installer-master-aro-unit
  • pull-ci-openshift-installer-master-e2e-aws-ovn
  • pull-ci-openshift-installer-master-e2e-vsphere-ovn
  • pull-ci-openshift-installer-master-e2e-vsphere-zones
  • pull-ci-openshift-installer-master-e2e-vsphere-zones-techpreview
  • pull-ci-openshift-installer-master-gofmt
  • pull-ci-openshift-installer-master-golint
  • pull-ci-openshift-installer-master-govet
  • pull-ci-openshift-installer-master-images
  • pull-ci-openshift-installer-master-okd-e2e-aws-ovn-upgrade
  • pull-ci-openshift-installer-master-okd-images
  • pull-ci-openshift-installer-master-okd-unit
  • pull-ci-openshift-installer-master-okd-verify-codegen
  • pull-ci-openshift-installer-master-shellcheck
  • pull-ci-openshift-installer-master-tf-fmt
  • pull-ci-openshift-installer-master-tf-lint
  • pull-ci-openshift-installer-master-unit
  • pull-ci-openshift-installer-master-verify-codegen
  • pull-ci-openshift-installer-master-verify-vendor
  • pull-ci-openshift-installer-master-yaml-lint

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vr4manta
Copy link
Contributor Author

/test altinfra-e2e-vsphere-capi-multi-vcenter-ovn

1 similar comment
@vr4manta
Copy link
Contributor Author

/test altinfra-e2e-vsphere-capi-multi-vcenter-ovn

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 22, 2024

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/altinfra-openstack-capi-manifests e4a7396 link true /test altinfra-openstack-capi-manifests
ci/prow/agent-integration-tests e4a7396 link true /test agent-integration-tests
ci/prow/e2e-agent-compact-ipv4 e4a7396 link true /test e2e-agent-compact-ipv4
ci/prow/altinfra-periodics-images e4a7396 link true /test altinfra-periodics-images
ci/prow/altinfra-e2e-vsphere-capi-multi-vcenter-ovn 00cc2e6 link false /test altinfra-e2e-vsphere-capi-multi-vcenter-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vr4manta @openshift-ci-robot @openshift-merge-robot