Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPLAT-1554: Added featuregate for multi vCenter support. #4298

Merged
merged 1 commit into from May 21, 2024
Merged

SPLAT-1554: Added featuregate for multi vCenter support. #4298

merged 1 commit into from May 21, 2024

Conversation

vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Apr 1, 2024 •
edited

SPLAT-1554

Changes

  • Bumped API version to get new FeatureGate

Dependencies

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 1, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 1, 2024 •
edited by openshift-ci bot

@vr4manta: This pull request references SPLAT-1554 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

SPLAT-1554

Changes

  • Bumped API version to get new FeatureGate
  • Modified single vCenter logic to allow more than one vCenter when new FeatureGate is enabled.

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2024
@vr4manta vr4manta force-pushed the SPLAT-1554 branch 3 times, most recently from b904fa2 to be300af Compare April 23, 2024 13:19
@vr4manta vr4manta mentioned this pull request May 6, 2024
Merged
@vr4manta vr4manta force-pushed the SPLAT-1554 branch 7 times, most recently from bbdb0fc to f3ac5fb Compare May 8, 2024 16:22
This was referenced May 9, 2024
Draft
Draft
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 9, 2024

@vr4manta: This PR was included in a payload test run from openshift/installer#8221
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2b3196f0-0dfa-11ef-91c8-1b3bdde4af13-0

@vr4manta
Copy link
Contributor Author

/test all

@vr4manta vr4manta marked this pull request as ready for review May 16, 2024 13:01
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 16, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 16, 2024 •
edited by openshift-ci bot

@vr4manta: This pull request references SPLAT-1554 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

SPLAT-1554

Changes

  • Bumped API version to get new FeatureGate

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jcpowermac
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 16, 2024

@vr4manta: This PR was included in a payload test run from openshift/installer#8221
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3dc68ee0-13a1-11ef-8e81-89f345da5761-0

@vr4manta
Copy link
Contributor Author

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 17, 2024

@vr4manta: This PR was included in a payload test run from openshift/installer#8221
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/652f0350-144a-11ef-979c-c7c5c682dc9f-0

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 17, 2024 •
edited

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change 2e61c70 link false /test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vr4manta
Copy link
Contributor Author

/assign jkyros
Ready for review.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 17, 2024

@vr4manta: This PR was included in a payload test run from openshift/installer#8221
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-installer-master-altinfra-periodics-e2e-vsphere-capi-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3383e5f0-1486-11ef-8537-9fe6a0f164a0-0

@djoshy
Copy link
Contributor

djoshy commented May 20, 2024

/retest-required

@djoshy
Copy link
Contributor

djoshy commented May 20, 2024

/test e2e-gcp-op-techpreview

@djoshy
Copy link
Contributor

djoshy commented May 20, 2024

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, jcpowermac, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a57f45f into openshift:master May 21, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhater-redhat dkhater-redhat Awaiting requested review from dkhater-redhat

@jkyros jkyros Awaiting requested review from jkyros

Assignees

@jcpowermac jcpowermac

@jkyros jkyros

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vr4manta @openshift-ci-robot @jcpowermac @djoshy @openshift-merge-robot @jkyros