Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop use of getManifolds #1234

Merged
merged 3 commits into from Apr 27, 2021
Merged

drop use of getManifolds #1234

merged 3 commits into from Apr 27, 2021

Conversation

dehann
Copy link
Member

@dehann dehann commented Apr 27, 2021

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #1234 (6b5be5d) into master (e6864ff) will increase coverage by 0.44%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1234      +/-   ##
==========================================
+ Coverage   73.49%   73.93%   +0.44%     
==========================================
  Files          55       55              
  Lines        4671     4608      -63     
==========================================
- Hits         3433     3407      -26     
+ Misses       1238     1201      -37     
Impacted Files Coverage Δ
src/Factors/EuclidDistance.jl 33.33% <0.00%> (+8.33%) ⬆️
src/IncrementalInference.jl 87.50% <ø> (ø)
src/SubGraphFunctions.jl 97.56% <ø> (-0.06%) ⬇️
src/Variables/DefaultVariables.jl 88.88% <ø> (-2.03%) ⬇️
src/Factors/LinearRelative.jl 88.88% <50.00%> (+7.93%) ⬆️
src/FGOSUtils.jl 71.51% <100.00%> (ø)
src/FactorGraph.jl 72.00% <100.00%> (+0.09%) ⬆️
src/GraphProductOperations.jl 96.29% <100.00%> (+0.37%) ⬆️
src/NeedsResolution.jl 7.69% <100.00%> (+7.69%) ⬆️
src/ParametricUtils.jl 65.07% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6864ff...6b5be5d. Read the comment docs.

@dehann dehann merged commit 059a076 into master Apr 27, 2021
Roadmap to V1.0 automation moved this from In progress to Completed Apr 27, 2021
@dehann dehann linked an issue Apr 27, 2021 that may be closed by this pull request
@dehann dehann deleted the 21Q2/refac/towards1141 branch August 13, 2021 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap to V1.0
  
Completed
Development

Successfully merging this pull request may close these issues.

Replace all instances of getManifolds with getManifold
1 participant