Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace all instances of getManifolds with getManifold #1233

Closed
dehann opened this issue Apr 25, 2021 · 2 comments · Fixed by #1234
Closed

Replace all instances of getManifolds with getManifold #1233

dehann opened this issue Apr 25, 2021 · 2 comments · Fixed by #1234
Labels
enhancement manifolds refactoring standardization
Projects
Roadmap to V1.0
Milestone
v0.25.0

Comments

@dehann
Copy link
Member

dehann commented Apr 25, 2021

Moving away from NTuple{Symbol} towards Manifolds.jl only. Related to JuliaRobotics/RoME.jl#244 and JuliaRobotics/ApproxManifoldProducts.jl#32
@dehann dehann added this to the v0.23.x milestone Apr 25, 2021
@dehann dehann added this to Improvements in Roadmap to V1.0 via automation Apr 25, 2021
@dehann dehann mentioned this issue Apr 27, 2021
Merged
@dehann dehann linked a pull request Apr 27, 2021 that will close this issue
drop use of getManifolds #1234
Merged
@dehann dehann modified the milestones: v0.24.x, v0.25.0 Jun 18, 2021
@dehann
Copy link
Member Author

dehann commented Aug 14, 2021

It appears all active instances of getManifolds in IIF has been removed. Other packages should clean up on their own.

@dehann dehann closed this as completed Aug 14, 2021
Roadmap to V1.0 automation moved this from Improvements to Completed Aug 14, 2021
@dehann dehann reopened this Sep 13, 2021
Roadmap to V1.0 automation moved this from Completed to Improvements Sep 13, 2021
@dehann
Copy link
Member Author

dehann commented Sep 13, 2021

Looks like we missed a few somewhere (noticed a warning during precompile, between AMP and IIF).

@dehann dehann closed this as completed Oct 3, 2021
Roadmap to V1.0 automation moved this from Improvements to Completed Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement manifolds refactoring standardization
Projects
Roadmap to V1.0
  
Completed
Milestone
v0.25.0
Development

Successfully merging a pull request may close this issue.

drop use of getManifolds JuliaRobotics/IncrementalInference.jl
1 participant
@dehann