-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Total Followers to Total Subscribers #23113
Rename Total Followers to Total Subscribers #23113
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @staskus!
There are other instances of "Followers" used instead of "Subscribers":
Do you prefer to update all of these now or merge this as-is?
I updated the only other instances of "Followers" on the Total Subscribers & Subscribers cards and their detail screens. There are more instances of "Followers" which I didn't update such as on the Jetpack Social Connections card, but I think this is out of scope. |
Fixes #23099 (comment) since some string updates got merged for 24.8 and some didn't.
I'll trigger another beta today which will submit new strings to glotpress.
To test:
Check Stats -> Insights tab. Total Followers should be renamed to Total Subscribers.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: