Stats Insights: Remove social (publicize) subscribers

[staskus]

Fixes #23085

Removing social (publicize) subscribers from:

• Insights -> Total Subscribers
• Insights -> Total Subscribers -> Details

Social (publicize) subscribers should no longer be account for when calculating total subscribers.

To test:

• Insights -> Total Subscribers card shouldn't contain publicize numbers (can be tested by comparing en.blog numbers in previous and current versions).
• Insights -> Total Subscribers -> Details chart should no longer contain Social subscribers.

Email subscribers will be removed when we make a final move to the Subscribers tab and remove existing elements from Insights tab.

Regression Notes

1. Potential unintended areas of impact

Make sure Insights continue working

2. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• VoiceOver.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• iPhone and iPad.
• Multi-tasking: Split view and Slide over. (iPad)

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23099-14312da
	Version	24.7
	Bundle ID	org.wordpress.alpha
	Commit	14312da
	App Center Build	WPiOS - One-Offs #9710

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23099-14312da
	Version	24.7
	Bundle ID	com.jetpack.alpha
	Commit	14312da
	App Center Build	jetpack-installable-builds #8754

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[guarani]

Looks good! Thanks!

I noticed that "Followers" was changed to "Subscribers" in 62a9471 while "Total Followers" remains the same:

I'm not sure if that was on purpose but we can adjust this later.

There's also a long-standing issue where the Total Subscriber number sometimes gets stuck on the count that doesn't include Email subscribers, and then pull-to-refresh fixes it and the correct (higher) number is shown. I created an issue here: #23110

[staskus]

I'm not sure if that was on purpose but we can adjust this later.

I dealt with Total Subscribers card in this PR:

#23084

Yes, but since this got merged just before the code freeze, 24.8 will contain some strings renamed and some not. 🤔

I spoke with David (who is release wrangler). We can merge #23113 and submit a new beta later today / tomorrow which will submit new strings to glotpress.

There's also a long-standing issue where the Total Subscriber number sometimes gets stuck on the count that doesn't include Email subscribers, and then pull-to-refresh fixes it and the correct (higher) number is shown. I created an issue here: #23110

Thanks for reporting, @guarani! Yes, I think moving to v2/subscribers for as many cases as possible will be a wise way to go.