New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update terminology to Subscribers from Followers #23126
Update terminology to Subscribers from Followers #23126
Conversation
cc @aditi-bhatia since you work on this task on Android. There're quite a few references of followers in the app that I found besides Stats. Most notably Notifications and Reader. |
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! This keeps "follow" for things like following a topic in Reader or following a post's comment.
Thanks for the heads up @staskus! I'm noticing and addressing those on Android too 👍 |
Fixes #21878
Update terminology to Subscribers from Followers in the app.
Other PRs that include renaming:
Solution
I used regex
"follow\w*\b.*?"
to find candidate strings for renaming:There are follow/follower references left in other contexts. For example, Jetpack Social Connections, or Topics. I concentrated on Blog's Followers/Follows/Following/Followed cases.
Affected places:
To test:
Note: Not all the changes I made appear on the project since
.strings
file still contain old strings and require them to be regenerated and retranslated."follow\w*\b.*?"
to check if any strings are missedRegression Notes
Make sure the strings are translated correctly at all the required places
Manual testing
PR submission checklist:
RELEASE-NOTES.txt
if necessary.Testing checklist: