Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update terminology to Subscribers from Followers #23126

Merged

Conversation

staskus
Copy link
Contributor

@staskus staskus commented Apr 30, 2024

Fixes #21878

Update terminology to Subscribers from Followers in the app.

Other PRs that include renaming:

Solution

I used regex "follow\w*\b.*?" to find candidate strings for renaming:
regular expression

There are follow/follower references left in other contexts. For example, Jetpack Social Connections, or Topics. I concentrated on Blog's Followers/Follows/Following/Followed cases.

Affected places:

  • Reader (although most popular buttons and prompts already have subscribers used instead of followers, there were still some unchanged strings left)
  • Notifications, NotificationSettings (similar to Stats it still used follower terminology)
  • Insights -> Grow Audience cell
  • Onboarding
  • Jetpack overlay
Notifications rename Notifications rename

To test:

  1. Check localized string changes on the PR.
  2. Check most prominent places:
  • Notifications
  • Notification Settings
  • Reader
  • Stats

Note: Not all the changes I made appear on the project since .strings file still contain old strings and require them to be regenerated and retranslated.

  1. Review the project with this or similar regex "follow\w*\b.*?" to check if any strings are missed

Regression Notes

  1. Potential unintended areas of impact

Make sure the strings are translated correctly at all the required places

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing

  1. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@staskus
Copy link
Contributor Author

staskus commented Apr 30, 2024

cc @aditi-bhatia since you work on this task on Android. There're quite a few references of followers in the app that I found besides Stats. Most notably Notifications and Reader.

@wpmobilebot
Copy link
Contributor

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23126-d1e2a1a
Version24.8
Bundle IDorg.wordpress.alpha
Commitd1e2a1a
App Center BuildWPiOS - One-Offs #9738
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23126-d1e2a1a
Version24.8
Bundle IDcom.jetpack.alpha
Commitd1e2a1a
App Center Buildjetpack-installable-builds #8783
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This keeps "follow" for things like following a topic in Reader or following a post's comment.

@staskus staskus merged commit da8f520 into trunk May 3, 2024
24 of 27 checks passed
@staskus staskus deleted the task/21878-update-terminology-to-subscribers-from-followers branch May 3, 2024 10:08
@aditi-bhatia
Copy link

cc @aditi-bhatia since you work on this task on Android. There're quite a few references of followers in the app that I found besides Stats. Most notably Notifications and Reader.

Thanks for the heads up @staskus! I'm noticing and addressing those on Android too 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update terminology to Subscribers from Followers
4 participants