Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate endianconv.c unit tests to new test framework #458

Merged
merged 10 commits into from May 12, 2024
Merged

Migrate endianconv.c unit tests to new test framework #458

merged 10 commits into from May 12, 2024

Conversation

karthyuom
Copy link
Contributor

This PR migrates all tests related to endianconv into new test framework as part of the parent issue #428.

@codecov Codecov
Copy link

codecov bot commented May 7, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.83%. Comparing base (cde8ec1) to head (98ba4e6).
Report is 19 commits behind head on unstable.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable     #458      +/-   ##
============================================
+ Coverage     68.91%   69.83%   +0.92%     
============================================
  Files           109      109              
  Lines         61793    61801       +8     
============================================
+ Hits          42582    43159     +577     
+ Misses        19211    18642     -569
Files Coverage Δ
src/endianconv.c 47.22% <ø> (ø)
src/server.c 88.60% <ø> (ø)

... and 36 files with indirect coverage changes

madolson
madolson reviewed May 7, 2024
View reviewed changes
src/unit/test_endianconv.c Outdated Show resolved Hide resolved
@karthyuom karthyuom changed the title Migrate endianconv unit tests to new test framework Migrate endianconv.c unit tests to new test framework May 10, 2024
@karthyuom
Copy link
Contributor Author

I didn’t remove the legacy endianconvTest from serverTest (see commit 1c59ca7 ) since it gives conflict which I couldn’t resolve anyway. I thought of doing it in a subsequent PR. I am not sure whethere there is any other alternative.

@karthyuom
Migrate endianconv unit tests to new test framework.
531f347 
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
@karthyuom
Introduce assertion to validate tests.
efbf476 
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
@karthyuom
RTry rsolve conflict.
45a141b 
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
@karthyuom
Try rsolve conflict.
1be4f33 
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
@karthyuom
Remove endianconvTest from serverTests.
c414ca1 
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
@karthyuom
Revert "Remove endianconvTest from serverTests."
d8507c4 
This reverts commit 6fcd60f.

Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
@karthyuom
Resolve conflict.
729e4ab 
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
@karthyuom
Remove endiantest.
4949bdc 
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
@karthyuom
This reverts commit 38c4375.
3fae284 
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
@karthyuom
Copy link
Contributor Author

@madolson could you please review and merge the above, thanks.

@karthyuom karthyuom mentioned this pull request May 11, 2024
Closed
@madolson
Update src/unit/test_endianconv.c
98ba4e6 
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
@madolson madolson merged commit c7ad9fe into valkey-io:unstable May 12, 2024
17 checks passed
@madolson madolson mentioned this pull request May 13, 2024
Open
12 tasks
adetunjii pushed a commit to adetunjii/valkey that referenced this pull request May 15, 2024
@karthyuom @madolson @adetunjii
Migrate endianconv.c unit tests to new test framework (valkey-io#458)
053587c 
This PR migrates all tests related to endianconv into new test framework
as part of the parent issue valkey-io#428.

---------

Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
adetunjii pushed a commit to adetunjii/valkey that referenced this pull request May 15, 2024
@karthyuom @madolson @adetunjii
Migrate endianconv.c unit tests to new test framework (valkey-io#458)
8bd9047 
This PR migrates all tests related to endianconv into new test framework
as part of the parent issue valkey-io#428.

---------

Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
Signed-off-by: adetunjii <adetunjithomas1@outlook.com>
adetunjii pushed a commit to adetunjii/valkey that referenced this pull request May 15, 2024
@karthyuom @madolson @adetunjii
Migrate endianconv.c unit tests to new test framework (valkey-io#458)
80b16a7 
This PR migrates all tests related to endianconv into new test framework
as part of the parent issue valkey-io#428.

---------

Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
Signed-off-by: adetunjii <adetunjithomas1@outlook.com>
hallmason17 pushed a commit to hallmason17/valkey that referenced this pull request May 15, 2024
@karthyuom @madolson @hallmason17
Migrate endianconv.c unit tests to new test framework (valkey-io#458)
23b0ea0 
This PR migrates all tests related to endianconv into new test framework
as part of the parent issue valkey-io#428.

---------

Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
hallmason17 pushed a commit to hallmason17/valkey that referenced this pull request May 18, 2024
@karthyuom @madolson @hallmason17
Migrate endianconv.c unit tests to new test framework (valkey-io#458)
9e03e68 
This PR migrates all tests related to endianconv into new test framework
as part of the parent issue valkey-io#428.

---------

Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
srgsanky pushed a commit to srgsanky/valkey that referenced this pull request May 19, 2024
@karthyuom @madolson @srgsanky
Migrate endianconv.c unit tests to new test framework (valkey-io#458)
3ba86b7 
This PR migrates all tests related to endianconv into new test framework
as part of the parent issue valkey-io#428.

---------

Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
adetunjii pushed a commit to adetunjii/valkey that referenced this pull request May 22, 2024
@karthyuom @madolson @adetunjii
Migrate endianconv.c unit tests to new test framework (valkey-io#458)
574af66 
This PR migrates all tests related to endianconv into new test framework
as part of the parent issue valkey-io#428.

---------

Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Madelyn Olson <madelyneolson@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com>
Signed-off-by: Samuel Adetunji <adetunjithomas1@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madolson madolson madolson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karthyuom @madolson