Migrate zmalloc.c unit tests to new test framework #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #459 +/- ##
============================================
+ Coverage 68.95% 69.80% +0.84%
============================================
Files 109 109
Lines 61793 61801 +8
============================================
+ Hits 42611 43138 +527
+ Misses 19182 18663 -519
|
karthyuom
changed the title
|
Same as this #458 (comment), I didn't remove legacy zmalloc_test due to the conflict. And, I will raise a follow-up PR to remove them together. @madolson In the meantime, could you please review and merge this PR, thanks. |
12 tasks
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Despite the fact that SO_REUSEADDR can be set on a Unix domain socket via setsockopt() without reporting an error, SO_REUSEADDR was actually created for ipv4/ipv6 and it's not supported for sockets of AF_UNIX. Therefore, setting this option on a Unix domain socket does nothing but costs one extra system call. Signed-off-by: Andy Pan <i@andypan.me> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
This PR migrates all tests related to util into new test framework as part of the parent issue valkey-io#428. --------- Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Updated redis instances accordingly as follows. rediscmd -> serverCmd freeRedisModuleAsyncRMCallPromise -> freeValkeyModuleAsyncRMCallPromise MyCommand_RedisCommand -> MyCommand_ValkeyCommand RedisModuleString -> ValkeyModuleString flushRedisModuleIOBuffer -> flushValkeyModuleIOBuffer Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
This PR migrates all tests related to kvstore into new test framework as part of the parent issue valkey-io#428. --------- Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Updated valkey in follwing functions. genRedisInfoString -> genValkeyInfoString genRedisInfoStringCommandStats -> genValkeyInfoStringCommandStats genRedisInfoStringACLStats -> genValkeyInfoStringACLStats genRedisInfoStringLatencyStats -> genValkeyInfoStringLatencyStats Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Fix the compile error with the following command: `make all-with-unit-tests SERVER_CFLAGS='-Werror -DSERVER_TEST' ` ``` /usr/bin/ld: /home/ubuntu/valkey-shiv-repo/valkey/src/eval.c:1172: undefined reference to `lua_next' /usr/bin/ld: /home/ubuntu/valkey-shiv-repo/valkey/src/eval.c:1154: undefined reference to `lua_toboolean' /usr/bin/ld: /home/ubuntu/valkey-shiv-repo/valkey/src/eval.c:1175: undefined reference to `lua_type' /usr/bin/ld: /home/ubuntu/valkey-shiv-repo/valkey/src/eval.c:1176: undefined reference to `lua_tonumber' collect2: error: ld returned 1 exit status make[1]: *** [Makefile:469: valkey-unit-tests] Error 1 make[1]: Leaving directory '/home/ubuntu/valkey-shiv-repo/valkey/src' make: *** [Makefile:6: all-with-unit-tests] Error 2 ``` Issue is happened as all deps libraries not linked for valkey-unit-tests, so linked all libraries to the binary. Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
This is a preparation for adding clang-format. These comments prevent automatic formatting in some places. With these exceptions, we will be able to run clang-format on the rest of the code. This is a preparation for valkey-io#323. --------- Signed-off-by: Viktor Söderqvist <viktor.soderqvist@est.tech> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
…fig. (valkey-io#415) Updated serverPanic output in db.c based on the extended-redis-compatibility config. and also updated comments in other files. --------- Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
All the intset unit tests are migrated to new test framework as part of valkey-io#344, but the old framework declaration is missed to remove from intset.h. So removed the code. Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
We currently has two disjoint TCL frameworks: 1. Normal testing framework, which trigger by runtest, which individually launches nodes for testing. 2. Cluster framework, which trigger by runtest-cluster, which pre-allocates N nodes and uses them for testing large configurations. The normal TCL testing framework is much more readily tested and is also automatically run as part of the CI for new PRs. The runtest-cluster since it runs very slowly (cannot be parallelized), it currently only runs in daily CI, this results in some changes to the cluster not being exposed in PR CI in time. This PR migrate the Cluster mode tests to normal framework. Some cluster tests are kept in runtest-cluster because of timing issues or not yet supported, we can process them later. Signed-off-by: Binbin <binloveplay1314@qq.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
This is a follow-up PR to address UNUSED repetition issue (see valkey-io#446 (comment)) in different test source files. Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
* `freeClientArgv` was previously defined in `server.h` * remove the redundant return Signed-off-by: arthur.lee <arthur-lee@qq.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Move dependency from `slowlog.c` into `slowlog.h`, make sure the language server can work properly under `slowlog.h` Signed-off-by: arthur.lee <arthur-lee@qq.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
This patch migrates all tests in sds.c into new test framework as part of the parent issue valkey-io#428. --------- Signed-off-by: Lipeng Zhu <lipeng.zhu@intel.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Before this PR, `pipe2()` is only enabled on Linux and FreeBSD while `pipe2()` is available on *BSD. This PR enables `pipe2()` for the rest of *BSD: DragonFlyBSD, NetBSD and OpenBSD. ## References - [pipe2 on DraonFlyBSD](https://man.dragonflybsd.org/?command=pipe§ion=2) - [__DragonFly_version for pipe2](https://github.com/DragonFlyBSD/DragonFlyBSD/blob/7485684fa5c3fadb6c7a1da0d8bb6ea5da4e0f2f/sys/sys/param.h#L121) - [pipe2 on NetBSD](https://man.netbsd.org/pipe.2) - [pipe2 on OpenBSD](https://man.openbsd.org/pipe.2) Signed-off-by: Andy Pan <i@andypan.me> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
…t slot away with allow-replica-migration enabled (valkey-io#466) Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
This migrates unit tests related to sha1 to new framework, ref: valkey-io#428. --------- Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com> Signed-off-by: Madelyn Olson <madelyneolson@gmail.com> Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Co-authored-by: Madelyn Olson <madelyneolson@gmail.com> Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
Signed-off-by: Karthick Ariyaratnam <karthyuom@gmail.com>
|
Please refer the PR #493. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates all tests related to zmalloc into new test framework as part of the parent issue #428.