Migrate unit tests to new framework

[madolson]

The legacy unit tests were a collection of distinct tests stored at the bottom of various files, that required rebuilding the server with a special flag and starting the server. We're moving to a new framework that can always be built and are running on a unified infrastructure. This issue is keeping track of migration from the old to new framework.

To migrate the tests, remove the custom testing code in the testing file lists listed below, create a new test like src/unit/test_*.c, and remove the reference in

valkey/src/server.c

Line 6890 in 5b1fd22

struct serverTest {

. See the README for more information about writing a new unit test.

• : Zipmap.c Migrate zipmap unit test to new framework #474
• : util.c Migrate util.c unit tests to new test framework #448
• : kvstore.c Migrate kvstore.c unit tests to new test framework. #446
• : dict.c
• : endianconv.c Migrate endianconv.c unit tests to new test framework #458
• : quicklist.c Migrate quicklist unit test to new framework #515
• : sds.c Migrate sds.c unit tests to new test framework. #478
• : sha1.c (Migrate sha1 unit test to new framework #470)
• : ziplist.c Migrate ziplist.c unit tests to new framework #486
• : zmalloc.c Migrate zmalloc.c unit tests to new test framework #459
• : listpack.c (Migrate listpack.c unit tests to new test framework #484)
• : Cleanup remaining references of SERVER_TEST

[SoulPancake]

Is there a part of this not WIP currently that I can pick up @madolson ?

[madolson]

@SoulPancake The only one not picked up right now is dict.c.

[jazelly]

I have tried porting dict.c under the new framework, but there is an issue with the test (or new test framework, or even dict.c itself). Reproduce steps

1. copy unit tests in dict.c to unit/test_dict.c
2. comment out original unit tests
3. update include in test_dict.c relatively. You will need #include "../dict.c" as there are some private functions used in the test.
4. you can choose to use the new test_help.h and change the print macro, but optional
5. make valkey-unit-tests
6. valkey-unit-tests --single test_dict.c
7. Observe the 3rd test getting segmentation fault on linux (stack overflow) or infinite loop on macos, caused by rehashidx always being 0

I've checked the new test framework but nothing could cause this inconsistency with original unit tests.