New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate zipmap unit test to new framework #474
Open
Shivshankar-Reddy
wants to merge
10
commits into
valkey-io:unstable
Choose a base branch
from
Shivshankar-Reddy:test-zipmap
base: unstable
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Migrate zipmap unit test to new framework #474
Shivshankar-Reddy
wants to merge
10
commits into
valkey-io:unstable
from
Shivshankar-Reddy:test-zipmap
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #474 +/- ##
============================================
+ Coverage 70.17% 70.20% +0.02%
============================================
Files 109 109
Lines 59904 59904
============================================
+ Hits 42039 42054 +15
+ Misses 17865 17850 -15
|
Shivshankar-Reddy
force-pushed
the
test-zipmap
branch
from
May 10, 2024 17:17
57d02f6
to
602407a
Compare
12 tasks
madolson
reviewed
May 13, 2024
Shivshankar-Reddy
force-pushed
the
test-zipmap
branch
from
May 16, 2024 13:09
602407a
to
22a3668
Compare
karthyuom
suggested changes
May 18, 2024
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
Shivshankar-Reddy
force-pushed
the
test-zipmap
branch
from
May 22, 2024 14:14
7ed6725
to
60788a1
Compare
Signed-off-by: Shivshankar-Reddy <shiva.sheri.github@gmail.com>
karthyuom
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate zipmap unit test to new unit test framework, parent ticket #428 .