Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflict with signinfo's temporary linguistic node sequence file caused test failures. #4625
Conflict with signinfo's temporary linguistic node sequence file caused test failures. #4625
Changes from all commits
2b19544
ad2e534
ae02884
c0adc5b
6c77dcf
3361d47
1ff0ca7
b907568
ef62d7e
6555fc9
0b0308f
80b46fd
043610e
66ecf2d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 71 in test/graphparser.cc
Codecov / codecov/patch
test/graphparser.cc#L71
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was the cause of the problem. In the multi-threaded environment the
test_linguistic_node.bin
was getting deleted for thegraphparser.cc
test.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this test also builds to the same directory as
graphparser.cc
? if so, shouldn't we change that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most are all running in the same directory. This test is testing specifically signs and is not building data. This is a temporary file as it is required for
CreateSignInfoList
We are not testing linguistic node signage here as it is done in the gurka tests. The real solution is to migrate the old tests to gurka.