Conflict with signinfo's temporary linguistic node sequence file caused test failures. #4625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinkreiser
previously approved these changes
Mar 11, 2024
|
Still having issues. Looking at it |
gknisely
changed the title
gknisely
commented
Mar 12, 2024
| @@ -30,7 +30,7 @@ TEST(Signinfo, ExitToTest) { | |||
| std::vector<SignInfo> signs; | |||
| std::vector<std::string> linguistics; | |||
| std::vector<std::pair<std::string, bool>> default_languages; | |||
| const std::string linguistic_node_file = "test_linguistic_node.bin"; | |||
| const std::string linguistic_node_file = "test_sign_linguistic_node.bin"; | |||
There was a problem hiding this comment.
This file was the cause of the problem. In the multi-threaded environment the test_linguistic_node.bin was getting deleted for the graphparser.cc test.
There was a problem hiding this comment.
so this test also builds to the same directory as graphparser.cc? if so, shouldn't we change that?
There was a problem hiding this comment.
Most are all running in the same directory. This test is testing specifically signs and is not building data. This is a temporary file as it is required for CreateSignInfoList We are not testing linguistic node signage here as it is done in the gurka tests. The real solution is to migrate the old tests to gurka.
dnesbitt61
previously approved these changes
Mar 12, 2024
reverted back
dnesbitt61
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
graphparser test is randomly failing. Ref: #4606 (comment)
Tasklist
Requirements / Relations
Link any requirements here. Other pull requests this PR is based on?