Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflict with signinfo's temporary linguistic node sequence file caused test failures. #4625

Merged
merged 14 commits into from Mar 12, 2024
Merged

Conflict with signinfo's temporary linguistic node sequence file caused test failures. #4625

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2b19544
updated path location so that we don't share the same as utrecht.cc test
gknisely Mar 11, 2024
ad2e534
updated
gknisely Mar 11, 2024
ae02884
more cleanup
gknisely Mar 11, 2024
c0adc5b
try cout
gknisely Mar 11, 2024
6c77dcf
revert back.
gknisely Mar 11, 2024
3361d47
testing
gknisely Mar 11, 2024
1ff0ca7
clean up
gknisely Mar 11, 2024
b907568
updated
gknisely Mar 12, 2024
ef62d7e
reverted
gknisely Mar 12, 2024
6555fc9
this was not the issue. can share dir
gknisely Mar 12, 2024
0b0308f
was using same test file.
gknisely Mar 12, 2024
80b46fd
reverted back.
gknisely Mar 12, 2024
043610e
Update CHANGELOG.md
gknisely Mar 12, 2024
66ecf2d
Update graphparser.cc
gknisely Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -96,6 +96,7 @@
* FIXED: Fixed roundoff issue in Tiles Row and Col methods [#4585](https://github.com/valhalla/valhalla/pull/4585)
* ADDED: isochrone proper polygon support & pbf output for isochrone [#4575](https://github.com/valhalla/valhalla/pull/4575)
* ADDED: return isotile grid as geotiff [#4594](https://github.com/valhalla/valhalla/pull/4594)
* FIXED: updated path location so that we don't share the same as utrecht.cc test [#4625](https://github.com/valhalla/valhalla/pull/4625)

## Release Date: 2023-05-11 Valhalla 3.4.0
* **Removed**
Expand Down
4 changes: 2 additions & 2 deletions test/graphparser.cc
View file
Open in desktop
Expand Up @@ -533,6 +533,7 @@ void Bike(const std::string& config_file) {
filesystem::remove(access_file);
filesystem::remove(from_restriction_file);
filesystem::remove(to_restriction_file);
filesystem::remove(bss_nodes_file);
filesystem::remove(linguistic_node_file);
}

Expand Down Expand Up @@ -677,7 +678,7 @@ void DoConfig() {
file << "{ \
\"mjolnir\": { \
\"id_table_size\": 1000, \
\"tile_dir\": \"test/data/parser_tiles\" \
gknisely marked this conversation as resolved.
Show resolved Hide resolved
\"tile_dir\": \"test/data/graph_parser_tiles\" \
} \
}";
} catch (...) {}
Expand Down Expand Up @@ -828,7 +829,6 @@ TEST(GraphParser, TestImportBssNode) {

filesystem::remove(ways_file);
filesystem::remove(way_nodes_file);
filesystem::remove(bss_nodes_file);
filesystem::remove(access_file);
filesystem::remove(from_restriction_file);
filesystem::remove(to_restriction_file);
Expand Down