Add skip_type_generation argument to generate_function to suppress type generation
#360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Anurag Makineni <anuragmanikeni@users.noreply.github.com>
| @@ -530,7 +532,8 @@ def generate_function( | |||
| shared_types=shared_types, | |||
| output_dir=os.fspath(output_dir), | |||
| lcm_bindings_output_dir=os.fspath(lcm_bindings_output_dir), | |||
| templates=templates, | |||
| # If not generating types, pass empty TemplateList to emission of files: | |||
| templates=templates if not skip_type_generation else template_util.TemplateList(), | |||
There was a problem hiding this comment.
From line 507 it seems like templates is already an empty TemplateList()?
Not sure if I'm missing something here.
|
I think you could also accomplish this by passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an optional argument to
generate_functionto allow skipping generation of any code-generation types (c++/python/lcm).When true, only the function code is generated and no other files are written. The logic proceeds normally otherwise, and the
typenames_dictandnamespaces_dictare filled out as expected.This configuration is useful if you intend to define types manually elsewhere, and want to suppress any extra emitted files.
This is a more minimal version of the proposal raised here: #183
CC @anuragmakineni