JavaScript backend core functionality #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-skydio
reviewed
Jun 3, 2022
…' into javascript-backend-core
This fixes Python not being able to properly generate functions that accept 1D and 2D matrix arguments.
|
@aaron-skydio this is ready for a pass now |
aaron-skydio
reviewed
Jun 6, 2022
| doc_comment_line_prefix: str = " * " | ||
| line_length: int = 100 | ||
| use_eigen_types: bool = True | ||
| # NOTE(hayk): Add JS autoformatter |
There was a problem hiding this comment.
Probably prettier? Which unfortunately doesn't seem to be on PyPI
| behavior for codegen compatibility and efficiency. | ||
| """ | ||
|
|
||
| def __init__(self, settings: T.Dict[str, T.Any] = None) -> None: |
There was a problem hiding this comment.
T.Mapping instead of T.Dict
| """ | ||
|
|
||
| def __init__(self, settings: T.Dict[str, T.Any] = None) -> None: | ||
| settings = dict(settings or {},) |
symforce/codegen/template_util.py
Outdated
Comment on lines
48
to
51
| elif extension == "ts": | ||
| return FileType.TYPESCRIPT | ||
| elif extension == "js": | ||
| return FileType.JAVASCRIPT |
There was a problem hiding this comment.
Probably leave typescript in here, unless we also delete it from the enum above?
| ) | ||
|
|
||
| def test_javascript_codegen(self) -> None: | ||
| for config in (codegen.PythonConfig(), codegen.CppConfig(), codegen.JavascriptConfig()): |
There was a problem hiding this comment.
Is the reasoning for generating it for all three just for debug purposes?
| @@ -0,0 +1,52 @@ | |||
| // ----------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
This should probably go in symforce_function_codegen_test_data? And use the pattern in the other codegen tests so it automatically generates on both backends
hmartiro
force-pushed
the
centralize-backend-specific-code
branch
2 times, most recently
from
3715c7d
to
5874834
Compare
hayk-skydio
changed the base branch from
centralize-backend-specific-code
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a javascript codegen backend to symforce. This change supports 1D and 2D matrices as javascript Array and Array of Arrays. It generates functions that run in node. It does not yet support geo, cam, or struct types.