installer/windows: installer automated testing #3558
+347
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
force-pushed
the
bryan/installer-testing
branch
from
56ea1b6
to
9e1a43f
Compare
bryanchriswhite
force-pushed
the
bryan/installer-testing
branch
from
e444414
to
9b3a649
Compare
bryanchriswhite
changed the base branch from
bryan/installer-automation
to
master
bryanchriswhite
force-pushed
the
bryan/installer-testing
branch
2 times, most recently
from
f05bf30
to
7762e36
Compare
bryanchriswhite
force-pushed
the
bryan/installer-testing
branch
from
7762e36
to
9df12b3
Compare
* storj/master: (63 commits) web/satellite: token payments logic (#3581) satellite/metainfo: reduce pointerDB access for CommitObject (#3589) satellite/metainfo: Fix misspelling in comment (#3636) argon2: choose a steady parallelism value (#3630) satellitedb: add support to testplanet for cockroachdb (#3634) satellite/console/auth: return in error handle added (#3639) Make sed a little more cross platformable (#3629) web: ms edge support bug fixed (#3638) web/satellite: registration/welcome message fixed, usage-report url fixed, storj-sim fixed (#3622) web/satellite: fonts changed to Inter (#3620) storagenode/updater: read identity location from storagenode's config.yaml (#3607) cmd/segment-reaper: Implement bitmask type (#3626) storagenode/gracefulexit: improve logging (#3633) private/testplanet: add a mock referral manager server into testplanet (#3631) satellite/gracefulexit: refactor concurrency (#3624) pkg/pb/referralmanager: update to add satellite ID to Get Tokens request (#3625) satellite/metainfo: improve Loop comments (#3595) storagenode: add bandwidth metrics (#3623) satellite/console: Add security headers (#3615) satellite/payments: token deposit accept cents (#3628) ...
bryanchriswhite
added
Code Review In-Progress
mniewrzal
reviewed
Nov 27, 2019
Fadila82
reviewed
Dec 3, 2019
mniewrzal
previously approved these changes
Dec 4, 2019
mniewrzal
reviewed
Dec 5, 2019
| @@ -118,6 +118,8 @@ func TestInstaller_Config(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestUpgrade_Config(t *testing.T) { | |||
| t.Skipf("upgrade test requires binaries to have greater version than \"old release\"") | |||
There was a problem hiding this comment.
I'm not sure whats the issue here
There was a problem hiding this comment.
Upgrade fails if the "new" msi is for an older version. Currently, unless HEAD is tagged with a version number, it's version is 0.0.0 which causes the upgrade test to fail when it uses a release msi for the "old" installation.
mniewrzal
approved these changes
Dec 5, 2019
kaloyan-raev
approved these changes
Oct 15, 2020
10 tasks
bryanchriswhite
commented
Oct 28, 2020
|
|
||
| const ( | ||
| // TODO: make this more dynamic and/or use versioncontrol server? | ||
| // (NB: can't use versioncontrol server until updater process is added to response) |
There was a problem hiding this comment.
This is exists now and could be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Test installation of the windows installer. The installer is expected to be built by the test environment prior to running the test and its path must be specified with the
-msiflag.Why: V3-3226
Please describe the tests:
TestInstaller_Config: asserts that the config.yaml is populated according to the properties used during installation.TestUpgrade_Config: asserts that when upgrading from one version to another the config.yaml is unchanged.TestService_StopStart: asserts that no errors occur when stopping/starting the installed services.Please describe the performance impact: N/A
Code Review Checklist (to be filled out by reviewer)