Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installer/testing: rebase bryan/installer-testing onto master #3957

Closed
wants to merge 95 commits into from
Closed

installer/testing: rebase bryan/installer-testing onto master #3957

wants to merge 95 commits into from

Conversation

bryanchriswhite
Copy link
Contributor

What: Rebases #3558 onto master.

Why: #3558 received a second approval by @kaloyan-raev 13 days ago.

Please describe the tests:

  • Test 1:
  • Test 2:

Please describe the performance impact:

Code Review Checklist (to be filled out by reviewer)

  • NEW: Are there any Satellite database migrations? Are they forwards and backwards compatible?
  • Does the PR describe what changes are being made?
  • Does the PR describe why the changes are being made?
  • Does the code follow our style guide?
  • Does the code follow our testing guide?
  • Is the PR appropriately sized? (If it could be broken into smaller PRs it should be)
  • Does the new code have enough tests? (every PR should have tests or justification otherwise. Bug-fix PRs especially)
  • Does the new code have enough documentation that answers "how do I use it?" and "what does it do?"? (both source documentation and higher level, diagrams?)
  • Does any documentation need updating?
  • Do the database access patterns make sense?

@bryanchriswhite bryanchriswhite requested a review from a team October 28, 2020 10:11
@cla-bot cla-bot bot added the cla-signed label Oct 28, 2020
@ghost ghost requested review from cam-a and thepaul and removed request for a team October 28, 2020 10:11
@bryanchriswhite bryanchriswhite changed the base branch from bryan/installer-testing to master October 29, 2020 08:42
@bryanchriswhite bryanchriswhite changed the title installer/testing: rebase bryan/installer testing onto master installer/testing: rebase bryan/installer-testing onto master Oct 29, 2020
bryanchriswhite and others added 23 commits October 29, 2020 09:44
@bryanchriswhite
add installer_test and fix typo in Product.wxs
a9eb137
@bryanchriswhite
wip2
5eefa16
@bryanchriswhite
add todo
2236cb2
@bryanchriswhite
download binaries instead of building
8f9ecfd
@bryanchriswhite
wip3
644c4b2
@bryanchriswhite
add todos and cleanup
4b3ead3
@bryanchriswhite
testing
165b00d
@bryanchriswhite
more testing
29c1630
@bryanchriswhite
wip
d098071
@bryanchriswhite
add build ignore
a10c370
@bryanchriswhite
add missing import
a4cf888
@bryanchriswhite
wip config test
e3d5626
@bryanchriswhite
fix path after move
8fd0253
@bryanchriswhite
fix installerDir var
10819cb
@bryanchriswhite
comment before uninstall
7b3b17f
@bryanchriswhite
fix assertions
380b260
@bryanchriswhite
add server address assertion
8ba31a7
@bryanchriswhite
cleanup
5691283
@Qweder93 @bryanchriswhite
SNOboard/console: router changed for gorillaMux, caching added (storj…
fe313f7 
…#3577)
@crawter @bryanchriswhite
satellite/payments: project usage charges (storj#3512)
0b58387
@mniewrzal @bryanchriswhite
storagenode/updater: recover command in Service Manager (storj#3425)
bf399fc
@rikysya @bryanchriswhite
satellite/payments: add API for retrieving conversion ratio, convert…
fb24191 
… tokens to USD before applying to balance (storj#3530)
@rikysya @bryanchriswhite
satellite/payments: switch to using STORJ tokens (storj#3582)
840d6d5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cam-a cam-a Awaiting requested review from cam-a

@thepaul thepaul Awaiting requested review from thepaul

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet