Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

installer/windows: installer automated testing #3558

Open
wants to merge 47 commits into
base: main
Choose a base branch
from
+347 −2
Open

installer/windows: installer automated testing #3558

Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
69480a7
add installer_test and fix typo in Product.wxs
bryanchriswhite Nov 12, 2019
b26b776
wip2
bryanchriswhite Nov 13, 2019
b369b57
add todo
bryanchriswhite Nov 13, 2019
523fac1
download binaries instead of building
bryanchriswhite Nov 15, 2019
2e98b40
wip3
bryanchriswhite Nov 15, 2019
9b3a649
add todos and cleanup
bryanchriswhite Nov 15, 2019
a7883c1
testing
bryanchriswhite Nov 15, 2019
235b453
more testing
bryanchriswhite Nov 20, 2019
6436269
wip
bryanchriswhite Nov 20, 2019
812756c
add build ignore
bryanchriswhite Nov 25, 2019
9df12b3
add missing import
bryanchriswhite Nov 25, 2019
1331c5d
wip config test
bryanchriswhite Nov 25, 2019
90292e2
fix path after move
bryanchriswhite Nov 25, 2019
3bc54ec
fix installerDir var
bryanchriswhite Nov 25, 2019
4c52c40
comment before uninstall
bryanchriswhite Nov 25, 2019
79afb92
fix assertions
bryanchriswhite Nov 25, 2019
f053602
add server address assertion
bryanchriswhite Nov 25, 2019
d0c157e
cleanup
bryanchriswhite Nov 25, 2019
2263a15
Merge remote-tracking branch 'storj/master' into bryan/installer-testing
bryanchriswhite Nov 25, 2019
ae34ded
uninstall tweaks
bryanchriswhite Nov 25, 2019
b2c9bae
add identitydir property
bryanchriswhite Nov 25, 2019
f9518e2
fix uninstall
bryanchriswhite Nov 25, 2019
7b42d0c
comment identity file
bryanchriswhite Nov 25, 2019
60c9e4f
close open file
bryanchriswhite Nov 25, 2019
ca7258e
test inprovements
bryanchriswhite Nov 25, 2019
2fec37c
wip testing
bryanchriswhite Nov 25, 2019
d3104a7
change version
bryanchriswhite Nov 25, 2019
51c497b
download installer
bryanchriswhite Nov 25, 2019
09f5aef
wait for services to stop
bryanchriswhite Nov 25, 2019
839935e
revert build.bat
bryanchriswhite Nov 25, 2019
515769a
use pre-downloaded/unpacked msi
bryanchriswhite Nov 25, 2019
6972204
use quiet msiexec
bryanchriswhite Nov 25, 2019
e16e702
cleanup
bryanchriswhite Nov 25, 2019
b8d77fe
refactor and wip upgrade testing
bryanchriswhite Nov 26, 2019
5379fd2
wip
bryanchriswhite Nov 26, 2019
f155b3f
fix upgrade test and cleanup
bryanchriswhite Nov 27, 2019
1a9fc9e
review improvements
bryanchriswhite Nov 27, 2019
40cafd6
add start/stop service test and refactor
bryanchriswhite Nov 27, 2019
3f72551
review improvements
bryanchriswhite Nov 27, 2019
88bba79
remove unused func
bryanchriswhite Nov 27, 2019
d0d8ef5
remove unnecesary flag check
bryanchriswhite Dec 2, 2019
a4e1aa8
remove unused variadic arg
bryanchriswhite Dec 2, 2019
7f65930
fix comment
bryanchriswhite Dec 3, 2019
1d7495f
add todo
bryanchriswhite Dec 3, 2019
a45c25f
add min storage property
bryanchriswhite Dec 4, 2019
958c5a6
use min storage prop
bryanchriswhite Dec 4, 2019
4d7a70f
skip upgrade
bryanchriswhite Dec 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions scripts/installer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ func TestInstaller_Config(t *testing.T) {
}

func TestUpgrade_Config(t *testing.T) {
t.Skipf("upgrade test requires binaries to have greater version than \"old release\"")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whats the issue here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade fails if the "new" msi is for an older version. Currently, unless HEAD is tagged with a version number, it's version is 0.0.0 which causes the upgrade test to fail when it uses a release msi for the "old" installation.


ctx := testcontext.New(t)
defer ctx.Cleanup()

Expand Down