Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace pkg_resources for python 3.12 #2831

Merged
merged 2 commits into from Apr 28, 2024

Conversation

branchvincent
Copy link
Contributor

Description

Follow up to #2312, Python 3.12 also removed bundled setuptools (aka pkg_resources)

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@branchvincent branchvincent changed the title replace pkg_resources for python 3.12 fix: replace pkg_resources for python 3.12 Apr 21, 2024
@branchvincent
Copy link
Contributor Author

Rebased to pick up 97f428b

@branchvincent
Copy link
Contributor Author

Looks like a network flake, can we rerun ci?

_______________________ ERROR collecting tests/tests.py ________________________
tests/tests.py:17: in <module>
    from .common import *
tests/common.py:72: in <module>
    not is_connected() or not has_gcloud_service_key(),
tests/common.py:49: in is_connected
    urllib.request.urlopen("http://www.google.com", timeout=1)
...
../../../micromamba/envs/snakemake/lib/python3.11/socket.py:706: in readinto
    return self._sock.recv_into(b)
E   TimeoutError: timed out
=========================== short test summary info ============================
ERROR tests/tests.py - TimeoutError: timed out

@johanneskoester johanneskoester enabled auto-merge (squash) April 28, 2024 18:54
Copy link

sonarcloud bot commented Apr 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@johanneskoester johanneskoester merged commit ac144fc into snakemake:main Apr 28, 2024
5 of 6 checks passed
@branchvincent branchvincent deleted the pkg_resources branch April 28, 2024 19:03
johanneskoester pushed a commit that referenced this pull request Apr 29, 2024
🤖 I have created a release *beep* *boop*
---


##
[8.11.1](v8.11.0...v8.11.1)
(2024-04-29)


### Bug Fixes

* check template rendering output for leaked input file paths
([#2850](#2850))
([433302e](433302e))
* do not distinguish between local and remote rules in dryrun
([74b99ec](74b99ec))
* omit norun jobs when determining remote storage input file retrieval
([#2854](#2854))
([37a7c7f](37a7c7f))
* Prevent binary log files to crash snakemake execution with
`show-failed-logs`
([#2827](#2827))
([8a80bda](8a80bda))
* replace pkg_resources for python 3.12
([#2831](#2831))
([ac144fc](ac144fc))
* return set instead of list when just --quiet
([#2829](#2829))
([eeb57e2](eeb57e2))
* small typo in error
([#2853](#2853))
([325a715](325a715))
* use keyword arguments in `_IOFile.open`
([#2847](#2847))
([50c84dc](50c84dc))


### Documentation

* fix typo and link for RO Crate
([#2851](#2851))
([cec0041](cec0041))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants