fix: Prevent binary log files to crash snakemake execution with show-failed-logs
#2827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
votti
changed the title
show-failed-logsshow-failed-logs
votti
force-pushed
the
fix/show-binary-logs
branch
from
2deb30a
to
2f25c1a
Compare
votti
changed the title
show-failed-logsshow-failed-logs
votti
force-pushed
the
fix/show-binary-logs
branch
from
2f25c1a
to
4b7a9cc
Compare
added 2 commits
April 22, 2024 08:42
This replicates snakemake#2826 Unfortunately this test seems to currently crush the pytest test execution when failing. Given that it should not fail any more I think this may be acceptable.
Previously a binary log file would cause `show_logs` to crash the whole snakemake workflow execution with a `UnicodeDecodeError`. Closes snakemake#2826
votti
force-pushed
the
fix/show-binary-logs
branch
from
4b7a9cc
to
7bddc8e
Compare
|
|
@test: I am not extremely happy about the test: currently the test is more on the integration test level, so I think it may be better to also add a unittest for |
|
Sure, a follow-up PR in that direction would be appreciated. Maybe it would need synchronization with #2830 |
johanneskoester
approved these changes
Apr 28, 2024
johanneskoester
pushed a commit
that referenced
this pull request
Apr 29, 2024
🤖 I have created a release *beep* *boop* --- ## [8.11.1](v8.11.0...v8.11.1) (2024-04-29) ### Bug Fixes * check template rendering output for leaked input file paths ([#2850](#2850)) ([433302e](433302e)) * do not distinguish between local and remote rules in dryrun ([74b99ec](74b99ec)) * omit norun jobs when determining remote storage input file retrieval ([#2854](#2854)) ([37a7c7f](37a7c7f)) * Prevent binary log files to crash snakemake execution with `show-failed-logs` ([#2827](#2827)) ([8a80bda](8a80bda)) * replace pkg_resources for python 3.12 ([#2831](#2831)) ([ac144fc](ac144fc)) * return set instead of list when just --quiet ([#2829](#2829)) ([eeb57e2](eeb57e2)) * small typo in error ([#2853](#2853)) ([325a715](325a715)) * use keyword arguments in `_IOFile.open` ([#2847](#2847)) ([50c84dc](50c84dc)) ### Documentation * fix typo and link for RO Crate ([#2851](#2851)) ([cec0041](cec0041)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #2826 currently the whole snakemake execution crashes if a log file is binary and
show-failed-logsis used.This fix prevents the crash by capturing the
UnicodeDecodeErrorand returning an error message that the log file is not a text instead.QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).