fix: remove extra call to setup_logger() #2809
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cademirch
changed the title
|
@johanneskoester could you take a look at this when you get a chance? Would be good to get this fixed before moving forward with monitoring plugin. |
Comment on lines
-526
to
-530
| self.snakemake_api.setup_logger( | ||
| stdout=executor_plugin.common_settings.dryrun_exec, | ||
| mode=self.workflow_api.workflow_settings.exec_mode, | ||
| dryrun=executor_plugin.common_settings.dryrun_exec, | ||
| ) |
There was a problem hiding this comment.
The reason for this extra call is that with calling execute, the dryrun info might be new, as well as the exec mode. One could of course offer a method to just update these in the logger api.
There was a problem hiding this comment.
Hmm, I'm not sure I follow. It seems setup logger is called here
Line 141 in 8a80bda
How can the the info be new by time execute is called? Regardless, I think you're right, we can provide setters for these in the logger
There was a problem hiding this comment.
Could we just do this instead of calling setup_logger()?
Suggested change
| self.snakemake_api.setup_logger( | |
| stdout=executor_plugin.common_settings.dryrun_exec, | |
| mode=self.workflow_api.workflow_settings.exec_mode, | |
| dryrun=executor_plugin.common_settings.dryrun_exec, | |
| ) | |
| logger.stdout = executor_plugin.common_settings.dryrun_exec | |
| logger.mode = self.workflow_api.workflow_settings.exec_mode | |
| logger.dryrun = executor_plugin.common_settings.dryrun_exec |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes seemingly extra call to setup_logger() in api, see #2797 for details.
Still not super familiar with API changes, so @johanneskoester please advise.
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).