Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Let wrapper log to stderr and stout file seperately. #2474

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

SilasK
Copy link
Contributor

@SilasK SilasK commented Oct 10, 2023

Description

allow log_fmt_shell to log to tow files.
This is for the use case if the log file of a script needs to be used without any sterr from the wrapper.

  If you provide two log files, name them err/out or sterr/stout.
  The function returns:

      2>> sterr > stout
      or with append=True
      2>> sterr >> stoud 

Appending to sterr is required as error messages from the wrapper will be overwritten otherwise.

Its used in snakemake/snakemake-wrappers#1322

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@SilasK SilasK changed the title Let wrapper log to tow files feat: Let wrapper log to stderr and stout file seperately. Nov 9, 2023
@SilasK SilasK changed the title feat: Let wrapper log to stderr and stout file seperately. feat!: Let wrapper log to stderr and stout file seperately. Nov 10, 2023
@SilasK
Copy link
Contributor Author

SilasK commented Nov 10, 2023

This would be ready @johanneskoester

Copy link

sonarcloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant