Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue1460 intermediate files existing (or not) #1541

Merged
merged 7 commits into from Apr 2, 2022
Merged

fix: issue1460 intermediate files existing (or not) #1541

merged 7 commits into from Apr 2, 2022

Commits on Mar 30, 2022

  1. chore: add testcase for issue #1460

    @johanneskoester @vsoch
    johanneskoester authored and vsoch committed Mar 30, 2022
    Copy the full SHA
    37f8b66 View commit details
    Browse the repository at this point in the history

  2. fix expected results

    @johanneskoester @vsoch
    johanneskoester authored and vsoch committed Mar 30, 2022
    Copy the full SHA
    5f51fda View commit details
    Browse the repository at this point in the history

  3. try force update of inventory after upload 

    Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Mar 30, 2022
    Copy the full SHA
    c04fb4c View commit details
    Browse the repository at this point in the history

  4. run gls tests first 

    Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Mar 30, 2022
    Copy the full SHA
    1666843 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2022

  1. pushing test fix 

    the issue is that the blob object held by a GS remote object can go sort
of stale, returning a False for blob.exists() when it clearly exists! To fix
we need to do an additional self.update_blob() and then returning the exists
check again. I am not sure if this can be made more efficient by only checking
under certain conditions, but since it seems likely we cannot perfectly know when
the blob has gone stale the sure way is to always update.

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Apr 2, 2022
    Copy the full SHA
    136b0e0 View commit details
    Browse the repository at this point in the history

  2. wrong version of black 

    Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Apr 2, 2022
    Copy the full SHA
    cee8b9d View commit details
    Browse the repository at this point in the history

  3. remove unused remote inventory, was just testing! 

    Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Apr 2, 2022
    Copy the full SHA
    5ffa061 View commit details
    Browse the repository at this point in the history