Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not wait for named or containerized conda envs #1473

Merged
merged 3 commits into from Mar 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions snakemake/jobs.py
Expand Up @@ -1015,7 +1015,10 @@ def get_wait_for_files(self):
self.dag.workflow.use_conda
and self.conda_env
and not self.conda_env.is_named
and not self.conda_env.is_containerized
):
# Named or containerized envs are not present on the host FS,
# hence we don't need to wait for them.
wait_for_files.append(self.conda_env.address)
return wait_for_files

Expand Down
22 changes: 22 additions & 0 deletions tests/test_github_issue1469/Snakefile
@@ -0,0 +1,22 @@
ruleorder: single_file > both_files


rule all:
input:
"foo.txt",
"bar.txt",


rule both_files:
output:
"foo.txt",
"bar.txt",
shell:
"if [[ -e foo.txt ]]; then exit 1; fi; touch {output}"


rule single_file:
output:
"foo.txt",
shell:
"if [[ -e foo.txt ]]; then exit 1; fi; touch {output}"