fix: display wrapper or external script code in report #1393 #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanneskoester
approved these changes
Feb 17, 2022
|
@cpauvert can you please format the code with black? |
…cpauvert/snakemake into fix1393-display-external-code-in-report
Thanks for the quick review @johanneskoester. And sorry for the bad formatting, it is better now in 9f5b62c |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi,
Thanks for keeping snakemake this active!
This PR fixes #1393. It only remove the call to the
decode()attribute of the source object (being either a script or a wrapper). From what I understood, such source object are read usingwithandopenwhere the encoding is already taken care since Python 3 (link).I tried to compare how the
get_sourcefunction got the script or wrapper code in the actual release and the one mentioned where external code display still worked (v6.4.1).I tried my best for generating the test, but seeing this is a visual inspection, I hope this is alright.
Best,
QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).