Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CondaEnvFileSpec lose the rule object to create new IOFile object #1373

Conversation

ddesvillechabrol
Copy link

Description

Hello !
This PR is a bugfix for the bug that broke the tests for snakemake-wrappers like this one snakemake/snakemake-wrappers#449.
The implementation with CondaEnvFileSpec seems to lose the rule object needed to create new IOFile object.
I am not sure but my bugfix may lead to memory leak.
Another solution is to pass the rule object when the apply_wildcards is called.
Cheers
Dimitri

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@johanneskoester
Copy link
Contributor

Thanks a lot, also for pointing me to the issue! Closing in favor of a slightly different fix (as you already suggest) in PR #1377.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants