fix: snakemake API using only 1 job as default #1283
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The snakemake API specifies:
However 16c34c8 introduced a "bug" where if you use the api, e.g.
snakemake.snakemake("Snakefile", cores=10)
then cores would be set properly to 10, butnodes
defaults to 1, so only one job at most works in parallel.This should be fixed with this tiny change.
QC
docs/
) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).edit
Ok somehow this gave an issue in the tests. The test needs 5 threads minimum due to many pipes, and only 3 were specified. That shouldn't have worked to begin with, so I would say this PR "works". However I'm not so sure why what I changed caused that bug to appear 🙃