Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: status cmd repeats until killed by 11 *different* signals #1207

Merged
merged 3 commits into from Oct 21, 2021
Merged

fix: status cmd repeats until killed by 11 *different* signals #1207

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
feaec5a
Count times status_cmd killed by same signal
epruesse Oct 7, 2021
1101960
fix typo (yes, "extend" and "append" are right next to each other)
epruesse Oct 7, 2021
dff7dfd
Merge branch 'main' into patch-2
johanneskoester Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions snakemake/executors/__init__.py
View file
Open in desktop
Expand Up @@ -1072,7 +1072,7 @@ def _wait_for_jobs(self):
success = "success"
failed = "failed"
running = "running"
status_cmd_kills = set()
status_cmd_kills = []
if self.statuscmd is not None:

def job_status(job, valid_returns=["running", "success", "failed"]):
Expand All @@ -1092,7 +1092,7 @@ def job_status(job, valid_returns=["running", "success", "failed"]):
# snakemake.
# Snakemake will handle the signal in
# the main process.
status_cmd_kills.add(e.returncode)
status_cmd_kills.append(-e.returncode)
if len(status_cmd_kills) > 10:
logger.info(
"Cluster status command {} was killed >10 times with signal(s) {} "
Expand Down