Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: issue with duplicated prefix for checkpoints on cloud #1199

Closed

Conversation

aryarm
Copy link
Member

@aryarm aryarm commented Sep 29, 2021

Implements a test to reproduce issue #574: checkpoints in cloud execution mode.

QC

  • The PR contains a test case for the changes or the changes are already covered by an existing test case.
  • The documentation (docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).

aryarm referenced this pull request in aryarm/snakemake Sep 29, 2021
@aryarm
Copy link
Member Author

aryarm commented Sep 29, 2021

@johanneskoester , I'm not really sure why the tests seemed to have passed in CI 😕

The new test didn't pass when I tried it locally... 🤔

@aryarm
Copy link
Member Author

aryarm commented Sep 30, 2021

hmm the checks seem to be passing, still :(
But on second thought, it doesn't look like the GLS tests are actually getting executed in the first place.

Maybe it's because the PR needs the update-container-image label like in #691? Can you add that label for me? I don't think I have permission.

@sonarcloud
Copy link

sonarcloud bot commented Oct 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aryarm
Copy link
Member Author

aryarm commented Oct 21, 2021

Ok, the newest CI error seems to indicate that the DOCKER_USERNAME secret isn't getting passed to the action correctly here.

Unable to find the username. Did you set with.username?

Can you verify that the secret is set correctly?

@aryarm aryarm changed the title test: issue with duplicate prefix checkpoints on cloud test: issue with duplicated prefix for checkpoints on cloud Oct 26, 2021
@johanneskoester
Copy link
Contributor

The problem is that you are on a fork. forks don't have access to all the necessary secrets. Let me do the following: you become part of the Snakemake organization, then you can re-issue your PR from within the original repo, not as a fork. Would that be ok for you?

@aryarm
Copy link
Member Author

aryarm commented Nov 25, 2021

Sure, that sounds good to me. As a long-time user of Snakemake, I really value having the opportunity to help contribute to it and give a little back to the community!

@johanneskoester
Copy link
Contributor

Awesome, you have an invitation now.

@aryarm
Copy link
Member Author

aryarm commented Dec 8, 2021

closing in favor of #1294

@aryarm aryarm closed this Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants