New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added tmpdir to all GATK wrappers, plus some doc changes #449
Conversation
Previous error was fixed with |
No idea what's wrong there. The google sdk should be a dependency of the full snakemake. |
And why an error on the linting check? If it was a missing dependency, shouldn't it give an error on the test? |
@johanneskoester it seems it was because of an old Snakefile, so I just deleted it. But no idea why.. 😄 |
Description
Added tmpdir (with tempfile) to all GATK wrappers, plus some doc changes
QC
For all wrappers added by this PR, I made sure that
input:
andoutput:
file paths in the resulting rule can be changed arbitrarily,threads: x
statement withx
being a reasonable default,map_reads
for a step that maps reads),environment.yaml
specifications follow the respective best practices,input:
oroutput:
),Snakefile
s and their entries are explained via comments (input:
/output:
/params:
etc.),stderr
and/orstdout
are logged correctly (log:
), depending on the wrapped tool,tempfile.gettempdir()
points to (see here; this also means that using any Pythontempfile
default behavior works),meta.yaml
contains a link to the documentation of the respective tool or command,Snakefile
s pass the linting (snakemake --lint
),Snakefile
s are formatted with snakefmt,