[python] Fix an ingestion corner case with empty chunks #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[sc-42637] |
|
This pull request has been linked to Shortcut Story #42637: AnnData ingest ZeroDivisionError. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2283 +/- ##
===========================================
+ Coverage 78.89% 90.94% +12.05%
===========================================
Files 139 36 -103
Lines 10718 3845 -6873
Branches 215 0 -215
===========================================
- Hits 8456 3497 -4959
+ Misses 2164 348 -1816
+ Partials 98 0 -98
Flags with carried forward coverage won't be shown. Click here to find out more.
|
johnkerl
changed the title
Shelnutt2
approved these changes
Mar 15, 2024
johnkerl
added a commit
that referenced
this pull request
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue and/or context: This is from a non-GitHub bug report.
Changes: Avoid division by zero on entirely empty chunks.
Notes for Reviewer: I tried to create synthetic data that would trigger the corner case, but failed to repro. Had I succeeded, I'd have created a new unit-test case on this PR. As is, I was only able to repro with some larger data I'm not willing to check in. Regardless, the change has been tested successfully against that dataset, and furthermore, it's a clear and solid code mod.