Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python] Fix an ingestion corner case with empty chunks #2283

Merged
merged 1 commit into from Mar 15, 2024
Merged

[python] Fix an ingestion corner case with empty chunks #2283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions apis/python/src/tiledbsoma/io/ingest.py
View file
Open in desktop
Expand Up @@ -2192,6 +2192,10 @@
if start_index + chunk_size >= extent:
return chunk_size

# The entire chunk is unoccupied sparse; the caller can skip over it
if chunk_nnz == 0:
return chunk_size

Check warning on line 2197 in apis/python/src/tiledbsoma/io/ingest.py

View check run for this annotation

Codecov / codecov/patch

apis/python/src/tiledbsoma/io/ingest.py#L2196-L2197 

Added lines #L2196 - L2197 were not covered by tests

# Compare initial estimate chunk nnz against the goal
ratio = chunk_nnz / goal_chunk_nnz

Expand Down