Windows: show the unread count on the task bar (Fixes #4788) #4831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove window.updateTrayIcon() - Move call to tray.updateIcon() into set-badge-count ipc handler Justification: ensure the badge count and tray icon are kept in sync with regard to the unread count.
Windows doesn't support the badge count like other OSes. Instead the badge count needs to be set as an overlay icon. See electron/electron#3148 As a result, for Windows, express the unread count as an overlay icon similar to what other messaging Electron apps do (e.g. Slack, Teams, etc).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
developmentbranchyarn readyrun passes successfully (more about tests here)Description
Fixes #4788.
Displays the unread message count on the Windows taskbar by using the Windows overlay API exposed by Electron:
See electron/electron#3148 for more info.
When the unread message count exceeds 9, the badge will show
9+similar to Microsoft Teams.Manually tested on Windows 10 64-bit by progressively marking conversations as unread (from 0 to well past 9 unread).