Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: show the unread count on the task bar (Fixes #4788) #4831

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Windows: show the unread count on the task bar (Fixes #4788) #4831

wants to merge 2 commits into from

Commits on Jan 14, 2021

  1. Refactor: DRY out setting tray and badge count with the unread count 

    - Remove window.updateTrayIcon()
- Move call to tray.updateIcon() into set-badge-count ipc handler

Justification: ensure the badge count and tray icon are kept in sync
with regard to the unread count.
    @rafd123
    rafd123 committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    a355b16 View commit details
    Browse the repository at this point in the history

  2. Windows: show the unread count on the task bar 

    Windows doesn't support the badge count like other OSes. Instead the
badge count needs to be set as an overlay icon.

See electron/electron#3148

As a result, for Windows, express the unread count as an overlay icon
similar to what other messaging Electron apps do (e.g. Slack, Teams,
etc).
    @rafd123
    rafd123 committed Jan 14, 2021
    Configuration menu
    Copy the full SHA
    da005ce View commit details
    Browse the repository at this point in the history