Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor ui glitch: 1.33.0 has a scrollbar in about window #4139

Open
foss- opened this issue Apr 8, 2020 · 4 comments · Fixed by #4147
Open

minor ui glitch: 1.33.0 has a scrollbar in about window #4139

foss- opened this issue Apr 8, 2020 · 4 comments · Fixed by #4147
Labels

Comments

@foss-
Copy link

foss- commented Apr 8, 2020

  • yes, I have searched open and closed issues for duplicates

Bug Description

macOS 10.15.4
Signal 1.33.0
Linked Device iOS 3.7.1.0

About window has a scrollbar since 1.33.0. Obviously low prio cosmetic glitch.

Steps to Reproduce

Open about window

Actual Result: scrollbar in about window

Expected Result: no scrollbar needed at that location

Screenshots

1 32 3
1 33 0

@scottnonnenberg-signal
Copy link
Contributor

Unfortunately, this is still happening in v1.33.4: #4147 (comment)

@foss-
Copy link
Author

foss- commented May 15, 2020

You meant 1.34.0?
1.34.0 looking good on macOS. So remaining problem might be windows only?

@scottnonnenberg-signal
Copy link
Contributor

Yep, I meant that it's still happening in v1.34.0 for at least one user.

@kaffarell
Copy link
Contributor

In the other pr I submitted (#4831), I discussed with josh about fixing this with overflow: hidden;. We discarded this idea because we will lose content (that is maybe added later and cut away). But maybe it is better solving it like this? Because this will solve the problem easily and should be pretty future-proof (in terms of screen-size and window-size).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

4 participants