Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/domain routing #536

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Feature/domain routing #536

wants to merge 3 commits into from

Conversation

mcheng89
Copy link
Contributor

@mcheng89 mcheng89 commented Mar 1, 2014

Moved #500 to develop branch.

Todo: add reverse routing for host (in progress)

@brendensoares brendensoares added this to the v0.10 milestone Mar 2, 2014
@brendensoares
Copy link
Member

@revel/core Do we really want Revel handling this level of HTTP? We need to decide now how deep down the rabbit hole we're going to go.

If Revel doesn't offer these features, then a proxy like nginx could. We could support fcgi or some environment variable passing for things like HTTP host.

Thoughts?

See #549.

@brendensoares
Copy link
Member

@mcheng89 Sorry to be critical of this PR when I wasn't with #500, but I want to make sure this is really going to add value to Revel for more than just a few developers.

Can you give some sample code demonstrating how this feature would be used given a couple example domains? How would domains be specified in the app routes and to which controllers would it be routed?

Thanks.

@pushrax
Copy link
Contributor

pushrax commented Mar 13, 2014

Again, I think * should be implied/default so you don't have to edit all the tests and examples. Sorry, looks like you already did that!

Besides that, I think this feature is reasonable, since it means that you don't need to run several Go processes to service a single site with multiple subdomains.

@mcheng89 mcheng89 closed this Mar 28, 2014
@brendensoares
Copy link
Member

Why is this closed @mcheng89 ?

@DSpeichert
Copy link

Anything I could do to help with getting this merged?

@notzippy notzippy added the status-doing Implementation has started label Jul 27, 2017
@notzippy
Copy link
Collaborator

Remove method from routepath and have it manually checked after route path is matched. See #1212

@rami-dabain
Copy link

Guy what happened with this MR?
This is really a great feature!

@notzippy
Copy link
Collaborator

We deferred this because we wanted to abstract the server engine, and we wanted to ensure the implementation would be backwards compatible with existing source trees. It is still open because we want to implement this at some point.

@notzippy notzippy added the Revel 2 Possibility for Revel 2 label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-should sooner rather than later Revel 2 Possibility for Revel 2 status-doing Implementation has started topic-config topic-domain-routing topic-routing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants