revel.Route.TreePath remove http method

[zuoRambo]

# routes file
...
GET /  App.Index
...

when i access http://localhost:9000/ with POST method, the server return response with status code 404.

I think it should be 405(method not allowed)

[notzippy]

The challenging part with that is Revel registers it as a miss on the router path since the route path starts with matching the method and working its way up. So when it looks up your request it looks for /GET/ to find App.Index and you could have a second like /PUT/ pointing to App.Index2 So in that case it hits it as a miss.

What could be done is that I add another route without the method (for methods which are defined) and if the first lookup fails then a second lookup could occur which may find a match and if a match is found we could set the status code to 405. Do you think that would work for you ?

[zuoRambo]

I think the point is how to to define router match and HTTP Status Code 405.

how about the pseudo-code below

if match PATH
    if match METHOD
        do action
    else
        return 405
else
    return 404

[notzippy]

There is a domain routing feature I have been eyeing that this could be implemented in. I added a reference back to this from there.

[zuoRambo]

Feature/domain routing #536 ? It looks like is not releated to my idea. 😢

[notzippy]

It has to do with changes to the router, I am putting them both together in that aspect.
thanks