[RETARGET] supports subdomain #358
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,7 +92,15 @@ type Router struct { | |||
| var notFound = &RouteMatch{Action: "404"} | |||
|
|
|||
| func (router *Router) Route(req *http.Request) *RouteMatch { | |||
| leaf, expansions := router.Tree.Find(treePath(req.Method, req.URL.Path)) | |||
| // by xiaoao[github.com/xiaoao] | |||
There was a problem hiding this comment.
Should not be tagging yourself in the code. It is in the git blame anyway.
|
ok,thank you |
|
@xiaoao you should write some unit tests ti ensure different subdomains are properly recognized (eg: some.domain.co.tld and other.long.sub.domains.com as well as a default for domain.com perhaps) |
Closed
|
@xiaoao have you been able to test that these changes work as expected? |
| @@ -15,6 +15,7 @@ import ( | |||
|
|
|||
| type Route struct { | |||
| Method string // e.g. GET | |||
| Subdomain string // e.g. subdomain:blog | |||
There was a problem hiding this comment.
Where is this being used once it's set?
Closed
|
@xiaoao how would you define your routes with subdomains? |
Closed
|
See also: #536 |
|
Closing this one in favor of hosts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this isn't a graceful way to support subdomain, and who will be nice enough to give me a better way
thx in advance