Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring near by link appraoch related code and example notebook #139

Merged
merged 31 commits into from Nov 10, 2023
Merged
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
58da506
refactor near by link appraoch related code and example notebook
maxmargraf Oct 27, 2023
05612b1
remove test of removed function
maxmargraf Oct 30, 2023
146c4df
update nearby wet dry test and remove test for dims for input as only…
maxmargraf Oct 30, 2023
07c62c9
require pmax in power correction
maxmargraf Oct 30, 2023
d260cb6
speeling errors..
maxmargraf Oct 30, 2023
0504854
update test to proper pmax behavior
maxmargraf Oct 30, 2023
7925716
black formatting
maxmargraf Oct 30, 2023
b30953c
update nearby example notebook
maxmargraf Oct 30, 2023
ebd150e
try to increase test coverage
maxmargraf Oct 30, 2023
f3a4b57
try to increase test coverage
maxmargraf Oct 30, 2023
5dc6632
try to increase test coverage
maxmargraf Oct 30, 2023
3f7ad15
extending docstrings and cosmetics
maxmargraf Oct 30, 2023
d1c6d76
update imports in notebook
maxmargraf Oct 30, 2023
7ce9c7e
correcting nearby k-R relation and test
maxmargraf Nov 6, 2023
1501c3d
implement review requests: mainly docstring enhancements, adding addt…
maxmargraf Nov 8, 2023
f65ffc8
updating example notebook
maxmargraf Nov 8, 2023
160ced8
add review suggestions: extending docstrings and adding comments
maxmargraf Nov 8, 2023
4a44fc6
coreccting typo and changing name of F_value_threshold
maxmargraf Nov 8, 2023
834339d
updating test for p_c_max calculation and making sure no negative att…
maxmargraf Nov 8, 2023
80549b9
updating notebook
maxmargraf Nov 8, 2023
b110ed2
update rainfall retrival test with more realistic pmax values
maxmargraf Nov 8, 2023
ba361c6
docstring update, cosmetics and black formatting update
maxmargraf Nov 8, 2023
20de35d
further docstring improvments
maxmargraf Nov 8, 2023
e86966d
further docstring improvments
maxmargraf Nov 9, 2023
cc98f10
Merge branch 'pycomlink:master' into refactoring_nearby
maxmargraf Nov 10, 2023
f8c86cf
remove testing raise which does not exist anymore
maxmargraf Nov 10, 2023
c68cf2e
update basic notebook with reference data from #136
maxmargraf Nov 10, 2023
25fabc4
implment new a_b() function
maxmargraf Nov 10, 2023
6e2b381
add xarray wrapper decorator to handle sublink dimension
maxmargraf Nov 10, 2023
dc0996e
cosmetics
maxmargraf Nov 10, 2023
bdc0d77
add a test for the nearby approach with real cml data
maxmargraf Nov 10, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view