Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring near by link appraoch related code and example notebook #139

Merged
merged 31 commits into from Nov 10, 2023
Merged

Refactoring near by link appraoch related code and example notebook #139

merged 31 commits into from Nov 10, 2023

Commits on Oct 27, 2023

  1. refactor near by link appraoch related code and example notebook

    @maxmargraf
    maxmargraf committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    58da506 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2023

  1. remove test of removed function

    @maxmargraf
    maxmargraf committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    05612b1 View commit details
    Browse the repository at this point in the history

  2. update nearby wet dry test and remove test for dims for input as only… 

    … one variable is passed anyway now
    @maxmargraf
    maxmargraf committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    146c4df View commit details
    Browse the repository at this point in the history

  3. require pmax in power correction

    @maxmargraf
    maxmargraf committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    07c62c9 View commit details
    Browse the repository at this point in the history

  4. speeling errors..

    @maxmargraf
    maxmargraf committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    d260cb6 View commit details
    Browse the repository at this point in the history

  5. update test to proper pmax behavior

    @maxmargraf
    maxmargraf committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    0504854 View commit details
    Browse the repository at this point in the history

  6. black formatting

    @maxmargraf
    maxmargraf committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    7925716 View commit details
    Browse the repository at this point in the history

  7. update nearby example notebook

    @maxmargraf
    maxmargraf committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    b30953c View commit details
    Browse the repository at this point in the history

  8. try to increase test coverage

    @maxmargraf
    maxmargraf committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    ebd150e View commit details
    Browse the repository at this point in the history

  9. try to increase test coverage

    @maxmargraf
    maxmargraf committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    f3a4b57 View commit details
    Browse the repository at this point in the history

  10. try to increase test coverage

    @maxmargraf
    maxmargraf committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    5dc6632 View commit details
    Browse the repository at this point in the history

  11. extending docstrings and cosmetics

    @maxmargraf
    maxmargraf committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    3f7ad15 View commit details
    Browse the repository at this point in the history

  12. update imports in notebook

    @maxmargraf
    maxmargraf committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    d1c6d76 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. correcting nearby k-R relation and test

    @maxmargraf
    maxmargraf committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    7ce9c7e View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. implement review requests: mainly docstring enhancements, adding addt… 

    …ional kwargs and fixing an error in p_c_max calculation as well as adopting tests
    @maxmargraf
    maxmargraf committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    1501c3d View commit details
    Browse the repository at this point in the history

  2. updating example notebook

    @maxmargraf
    maxmargraf committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    f65ffc8 View commit details
    Browse the repository at this point in the history

  3. add review suggestions: extending docstrings and adding comments

    @maxmargraf
    maxmargraf committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    160ced8 View commit details
    Browse the repository at this point in the history

  4. coreccting typo and changing name of F_value_threshold

    @maxmargraf
    maxmargraf committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    4a44fc6 View commit details
    Browse the repository at this point in the history

  5. updating test for p_c_max calculation and making sure no negative att… 

    …enuation is used in the k-R relation
    @maxmargraf
    maxmargraf committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    834339d View commit details
    Browse the repository at this point in the history

  6. updating notebook

    @maxmargraf
    maxmargraf committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    80549b9 View commit details
    Browse the repository at this point in the history

  7. update rainfall retrival test with more realistic pmax values

    @maxmargraf
    maxmargraf committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    b110ed2 View commit details
    Browse the repository at this point in the history

  8. docstring update, cosmetics and black formatting update

    @maxmargraf
    maxmargraf committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    ba361c6 View commit details
    Browse the repository at this point in the history

  9. further docstring improvments

    @maxmargraf
    maxmargraf committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    20de35d View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. further docstring improvments

    @maxmargraf
    maxmargraf committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    e86966d View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Merge branch 'pycomlink:master' into refactoring_nearby

    @maxmargraf
    maxmargraf committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    cc98f10 View commit details
    Browse the repository at this point in the history

  2. remove testing raise which does not exist anymore

    @maxmargraf
    maxmargraf committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    f8c86cf View commit details
    Browse the repository at this point in the history

  3. update basic notebook with reference data from pycomlink#136

    @maxmargraf
    maxmargraf committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    c68cf2e View commit details
    Browse the repository at this point in the history

  4. implment new a_b() function

    @maxmargraf
    maxmargraf committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    25fabc4 View commit details
    Browse the repository at this point in the history

  5. add xarray wrapper decorator to handle sublink dimension

    @maxmargraf
    maxmargraf committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    6e2b381 View commit details
    Browse the repository at this point in the history

  6. cosmetics

    @maxmargraf
    maxmargraf committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    dc0996e View commit details
    Browse the repository at this point in the history

  7. add a test for the nearby approach with real cml data

    @maxmargraf
    maxmargraf committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    bdc0d77 View commit details
    Browse the repository at this point in the history