Refactoring near by link appraoch related code and example notebook

[maxmargraf]

This PR should refactor the nearby link approach.
Todos:

• remove function instantaneous_to_minmax_data()
• move the calculation of max(pmin), deltaP and deltaPL to nearby_wetdry()
• update nearby_determine_reference_level() and nearby_correct_recieved_signals() to make the usage of pmax more intuitive
• update of the example notebook and its descriptions to match the changes in the functions above
• update test_nearby_wetdry()
• update test_nearby_rainfall()

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (975242b) 75.17% compared to head (bdc0d77) 74.83%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
- Coverage   75.17%   74.83%   -0.35%     
==========================================
  Files          29       29              
  Lines        1112     1089      -23     
==========================================
- Hits          836      815      -21     
+ Misses        276      274       -2     

Flag	Coverage Δ
unittests	74.83% <100.00%> (-0.35%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
pycomlink/processing/nearby_rain_retrival.py	100.00% <100.00%> (+4.00%)	⬆️
pycomlink/processing/wet_dry/nearby_wetdry.py	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[cchwala]

Thanks for all the updates! I mainly have some comments regarding doc strings, but also one regarding a potential error in the code.

Two additional comment to the notebook:

You can remove that from the first cell I guess

%load_ext autoreload
%autoreload 2

import nearby_rain_retrival as nearby_rain
import nearby_wetdry as nearby_wetdry

I am confused about this part in the last cell

As reference, path-averaged rain rates along the CMLs paths from RADKLIM-YW are provided. This data has a temporal resolution of 5 minutes and is resampled to 15 minute rainfall intensities.

But then you do

path_ref.sel(cml_id=i).rainfall_amount.resample(time="15min").sum() * 4)

If path_ref is already the 5-minute rain rate from RADKLIM-YW (as stated in your text), it should be best to just do .resample(time="15min").mean(), right? Or is path_ref` not a rain rate? Either your text or you code is wrong.

[cchwala]

Thanks for the swift update.

I still found some minor things that should be updated. Then it is ready to merge.

The notebook also looks good now. The plots with the time series of p_c_min and p_c_max really help to understand what the individual variables mean. 👍

[maxmargraf]

Thanks for the review comments! Ready to be merged from my side.

[cchwala]

Thanks a lot again 👏 👏 👏 .

Really good to now have this updated implementation of the nearby-link approach from RAINLINK in Python! 🎉