Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Search bar to Maps . #2582

Open
1 of 2 tasks
sagarpreet-chadha opened this issue Apr 3, 2018 · 6 comments
Open
1 of 2 tasks

Adding Search bar to Maps . #2582

sagarpreet-chadha opened this issue Apr 3, 2018 · 6 comments
Assignees
Labels
has-pull-request issues which already have a pull request solving it JavaScript Ruby

Comments

@sagarpreet-chadha
Copy link
Contributor

sagarpreet-chadha commented Apr 3, 2018

Please describe the problem (or idea)

Currently the maps do not have the ability to search a marker . Lets add a search-bar button to maps using this plugin https://www.npmjs.com/package/leaflet-search .

Tasks :

  • Adding a search-bar button to /peoples map to search person by name .

  • Similarly adding the Search-bar button to all the inline maps .

Mock-up :

screen shot 2018-04-03 at 11 38 30 pm

To know more about Power Tags and Inline Tags :
https://publiclab.org/wiki/inline-maps
https://publiclab.org/wiki/power-tags

Thank you!

@sagarpreet-chadha
Copy link
Contributor Author

sagarpreet-chadha commented Apr 3, 2018

@jywarren ... working on the /people map first to search markers using User name 🎈 🗺 😄 .

@sagarpreet-chadha
Copy link
Contributor Author

Part 4 of #1934 .

@sagarpreet-chadha sagarpreet-chadha added the has-pull-request issues which already have a pull request solving it label Apr 4, 2018
jywarren pushed a commit that referenced this issue Apr 6, 2018
* Added CDN links for Map search Feature

* Searching via User name
@sagarpreet-chadha
Copy link
Contributor Author

@jywarren , @ebarry

screen shot 2018-06-29 at 9 59 23 pm

Should we continue this feature to inline maps ?
If we use this plugin which is used here , we cannot search the location(country , city , etc.) .

@jywarren
Copy link
Member

jywarren commented Jun 29, 2018 via email

@sagarpreet-chadha
Copy link
Contributor Author

Hi @jywarren ,

I think searching of location on a map can be done using google autocomplete + google place API and figuring how to make a search_bar on the map . I guess it would be best to make a separate library for this feature ?
Also will this feature help people in using various maps across the site ?

What do you think of this ? Thanks !

@jywarren
Copy link
Member

jywarren commented Jan 3, 2019 via email

SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this issue May 5, 2019
* Added CDN links for Map search Feature

* Searching via User name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-pull-request issues which already have a pull request solving it JavaScript Ruby
Projects
None yet
Development

No branches or pull requests

2 participants