Update Paperclip to v5 #2589
Update Paperclip to v5 #2589
Conversation
Generated by 🚫 Danger |
|
I'm testing this out at https://unstable.publiclab.org! |
|
Hmm, @icarito No rush but it seems unstable is not booting? |
|
Hey Jeff, just looked at this, I had messed with docker-compose-unstable.yml when working on #2495. I'll make a pr to include dockerfiles for different instances, it would be a pain to update this stuff in many places. |
|
Ok! Where are the changes I have to look at? Thanks!!! |
|
Actually I was wondering too, do I deploy everything that is in /Master?
/
Currently /unstable/ doesn't carry the changes in mail configuration.
Unstable has this:
1. Removed de.yml files from /config/locales/ (#2551) (detail
<https://jenkins.laboratoriopublico.org/job/Plots-Unstable/70/changes#detail0> / githubweb
<894fa33>)
2. tags not shown on search resolved (#2578) (detail
<https://jenkins.laboratoriopublico.org/job/Plots-Unstable/70/changes#detail1> / githubweb
<82f2096>)
3. Popup on tags display added (#2572) (detail
<https://jenkins.laboratoriopublico.org/job/Plots-Unstable/70/changes#detail2> / githubweb
<e1a1866>)
4. Upgrade to Rails 4.2 (#2533) (detail
<https://jenkins.laboratoriopublico.org/job/Plots-Unstable/70/changes#detail3> / githubweb
<9795328>)
5. [WIP] Adding Search bar to Maps . #2582 (#2585) (detail
<https://jenkins.laboratoriopublico.org/job/Plots-Unstable/70/changes#detail4> / githubweb
<35aeac4>)
6. Update Gemfile (detail
<https://jenkins.laboratoriopublico.org/job/Plots-Unstable/70/changes#detail5> / githubweb
<cdab697>)
7. updated Gemfile.lock (detail
<https://jenkins.laboratoriopublico.org/job/Plots-Unstable/70/changes#detail6> / githubweb
<b7e266e>)
…On 08/04/18 07:38, Jeffrey Warren wrote:
Ok! Where are the changes I have to look at? Thanks!!!
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#2589 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMMS9PV7zjWB2k5hPK7oeRAMWj0QBZhks5tmgSrgaJpZM4TKpKB>.
|
|
This change has not been put into master. This is just the Paperclip upgrade, not the Rails 4.2 upgrade -- the latter has been put into master, and is ready for deployment. The mail configuration has been merged to master, and is ready for deployment and email testing, and is unrelated to either the Rails 4.2 upgrade or this Paperclip change (paperclip is just image uploading). Here, I was trying to push this attempt at Paperclip image/file upload to unstable before merging it -- it's lower priority! Thanks! |
|
So, you should be able to deploy everything in master to stable, then to production (email configs haven't been moved to stable yet because I wasn't sure if you'd finished with the stable email config) |
|
^ edited above to say "everything in master to stable" instead of just "everything" |
|
Cool then I'll be testing the mail settings in stable to deploy and test
production.
…On 08/04/18 12:52, Jeffrey Warren wrote:
^ edited above to say "everything in master to stable" instead of just
"everything"
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#2589 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMMS2D2-Lm5ejpIEVR2eBmoz23U-1GAks5tmk5dgaJpZM4TKpKB>.
|
|
Jeff, I deployed to production and to stable. |
|
Awesome thanks!
…On Mon, Apr 9, 2018, 2:59 AM Sebastian Silva ***@***.***> wrote:
Jeff, I deployed to production and to stable.
I did a bit of a trick, adding appropriate IP address for SMTP service to
/etc/hosts file (by default plots looks for smtp hostname).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2589 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ_uOTEEC-nVIxOkQeYKIThSlakKvks5tmwa-gaJpZM4TKpKB>
.
|
|
Hmm, @icarito it looks like this took Unstable offline; https://unstable.publiclab.org/ is it related? I just want to test this out before merging to master, since it affects image upload. Thanks! |
|
Actually it looks more subtle -- see https://jenkins.laboratoriopublico.org/job/Plots-Unstable/74/console I wasn't able to push this to unstable, it seems, at all? |
|
I recently upgraded the Jenkins container setup to correctly map tycho's
users and groups. Permissions may become wrong if one uses git directly
in tycho and one's user's umask doesn't give group write permissions by
default. Sorry!
…On 16/04/18 10:43, Jeffrey Warren wrote:
Hmm, @icarito <https://github.com/icarito> it looks like this took
Unstable offline; https://unstable.publiclab.org/ is it related?
I just want to test this out before merging to master, since it
affects image upload. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2589 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMMSyzeZcg1h5xpB7Tors8SFpRy_Lpvks5tpLwbgaJpZM4TKpKB>.
|
|
It's deployed now!
…On 16/04/18 10:49, Jeffrey Warren wrote:
Actually it looks more subtle -- see
https://jenkins.laboratoriopublico.org/job/Plots-Unstable/74/console
I wasn't able to push this to unstable, it seems, at all?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2589 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMMSwfTztEBV8com_3ypvyjDXxJG6WXks5tpL2FgaJpZM4TKpKB>.
|
|
Oh super - tested and this works -- merging now! |
|
And our warning is gone! Super work, thanks!!! |
* Update Gemfile * updated Gemfile.lock
Will need Gemfile.lock too!