[WIP] Adding Search bar to Maps . #2582 #2585
Conversation
Generated by 🚫 Danger |
|
This sounds really good - also, GREAT EMOJI USE HERE 😄 😆 Do we need to zoom back out? Also, i had originally thought that the search box could be for geocoding, so to type in, for example I kind of wish the UI used Bootstrap elements, don't you? I wonder if there's any way to do that. Great work!! |
| }); | ||
| map<%= unique_id %>.addControl(controlSearch<%= unique_id %>); | ||
| /* | ||
| controlSearch<%= unique_id %>.on('search:collapsed', function(e) { |
There was a problem hiding this comment.
So this is basically an Event Listener which is triggered when the search bar collapses .
Currently commented out .
There was a problem hiding this comment.
I have commented the zoom-out feature for now .
| } | ||
| var map<%= unique_id %> = L.map('map<%= unique_id %>').on('load', onMapLoad).setView([<%= lat %>,<%= lon %>], 2); | ||
| L.tileLayer("//a.tiles.mapbox.com/v3/jywarren.map-lmrwb2em/{z}/{x}/{y}.png").addTo(map<%= unique_id %>); | ||
| var searchLayer<%= unique_id %> = L.layerGroup().addTo(map<%= unique_id %>); |
There was a problem hiding this comment.
Given <%=unique_id %> because we may have more than 1 /people map (inline) on a page . So we need unique variable name 😄 .
|
This is part of CDN link code , i am wondering whether the search-icon will appear in the production ? The layer icon is not available on /profile page . See I think it should work on production because What do you think ? |
|
GIF : |
|
OK, i may try to tweak the CSS a bit once it goes into production but it needn't stop us right now. Do you think it's ready to merge? Thank you!!! |
|
Yes ...i think it is ready to merge then . |
|
Hi @sagarpreet-chadha , I am just asking the question out of curiosity. 😄 |
|
Great -- will do after #2533!! |
|
Hi @sukhbir-singh ! I first do the screen recording 🎥 of the feature 😄 . Its kind of a long task but it really makes the life of the reviewer easy 🙈 . Thanks ! |
|
There is also this one: https://www.cockos.com/licecap/ which is Windows
and Mac OS
…On Fri, Apr 6, 2018 at 2:50 PM, Sagarpreet Chadha ***@***.***> wrote:
Hi @sukhbir-singh <https://github.com/sukhbir-singh> !
I first do the screen recording 🎥 of the feature 😄 .
Then i use this site https://ezgif.com/video-to-gif to convert the video
🎞 📽 into the gif .
Its kind of a long task but it really makes the life of *reviewer* easy 🙈
. Thanks !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2585 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ3I_I5Bl3FtLW7KURHe8eaPlztJ7ks5tl8cXgaJpZM4TG6J6>
.
|
|
And for ubuntu Peek https://github.com/phw/peek works good 😅 |
|
Thank you @sagarpreet-chadha for the reply. yeah!! that's true the gifs makes the review process quite exciting. Looks like licecap is also good one for the purpose. Thanks @jywarren for info. but I actually use fedora linux. I'm a big fan of linux distro 😃 @Gauravano Thanks I will try peek 👍 |
* Added CDN links for Map search Feature * Searching via User name
Solves First Part of #2582 .
🔍 🗺
rake testfixes #0000-style reference to original issue #@publiclab/reviewersfor help, in a comment belowThanks!