Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planning Overview #1

Closed
9 of 15 tasks
sagarpreet-chadha opened this issue Apr 30, 2018 · 28 comments
Closed
9 of 15 tasks

Planning Overview #1

sagarpreet-chadha opened this issue Apr 30, 2018 · 28 comments
Labels

Comments

@sagarpreet-chadha
Copy link
Collaborator

sagarpreet-chadha commented Apr 30, 2018

Plots2 issue : publiclab/plots2#2486

Layers to include


Layer submission

We should create a clear process for:

  1. requesting a new layer
  2. collecting links and docs, and
  3. adding it to the library in a consistent way

UI/Navigation

I have implemented a search-bar feature on https://publiclab.org/people/ . Note that the search-bar 🔍 searches the people on map and not a particular location/place on map !
(publiclab/plots2#2582)

Testing :

🔜

Release :

🔜

@jywarren
Copy link
Member

Great -- can you link to the example search feature you put together, and note that it's for re-centering the map, not searching for content on the map?

Also the relative issue links won't work so i fixed it by adding https://github.com/publiclab/plots2 before the #

@jywarren
Copy link
Member

Added a couple more layers and then links to APIs and libraries. Great!

@jywarren
Copy link
Member

What do you think?

@jywarren
Copy link
Member

jywarren commented May 6, 2018

This is looking awesome btw!

@sagarpreet-chadha
Copy link
Collaborator Author

Hi @jywarren !
Kindly have a look at https://publiclab.github.io/leaflet-environmental-layers/example/mapSimple.html .
Completed JusticeMap layer :)
screen shot 2018-05-25 at 2 10 30 am

@jywarren
Copy link
Member

Amazing!!! !!!!! So great. I love this.

Just a thought about the SkyTruth alerts -- i think they may be getting truncated? See how they seem to be on a grid - are we losing precision?

leaflet

Also can we make the demo full window size?

@jywarren
Copy link
Member

We may need to think about a more sophisticated UI for turning on/off layers and having explanations for what they are! Let's do this much later though :-)

@sagarpreet-chadha
Copy link
Collaborator Author

The markers are getting removed due to :

clearOutsideBounds: function () {

I guess i should turn this listener off .
Will make the changes ASAP 👍 !
Thanks 😄 !

@jywarren
Copy link
Member

But do you see what i mean about precision? If they've been truncated, they might appear on a kind of grid at that lower resolution - like if 14.103251 became 14.10 for example.

Awesome! Also adding a note to try linking public comments map via Scott Eustis (i'll add more detail later)

@sagarpreet-chadha
Copy link
Collaborator Author

Oh i missed your point earlier ... Yes the markers seems to appear on a grid .
Will look at it . Thanks !

@sagarpreet-chadha
Copy link
Collaborator Author

Great catch @jywarren 🎉 !!! Yes i was using parseInt() to truncate the precision .
Done the changes 🔨 , kindly have a look !

@jywarren
Copy link
Member

works perfectly. Great work and I'm seeing wind data too! :-)))

@sagarpreet-chadha
Copy link
Collaborator Author

Hi @jywarren !
There are 2 PR's for mapknitter and toxicRelease Inventory . Currently working on fastTracker Layer (figuring out the API as of now) . What should we do next ?

@jywarren
Copy link
Member

jywarren commented Jun 14, 2018 via email

@sagarpreet-chadha
Copy link
Collaborator Author

mapknitter layer and ToxicRelease Layer pushed to gh-pages branch .

@sagarpreet-chadha
Copy link
Collaborator Author

@jywarren
Wunderground API shows same data as OpenWeatherMap API .
What do you think ?

This is the current OpenWeatherMap Layer we have :
Solved in this commit : f38d594
(Did not made a separate PR for this Layer ! )

screen shot 2018-06-26 at 4 28 45 pm

@jywarren
Copy link
Member

jywarren commented Jun 26, 2018 via email

@sagarpreet-chadha
Copy link
Collaborator Author

@jywarren ...to get data from epa site , we have to contact them .

ALSO we can show Power , Telecom , Petroleum , Water layers from https://openinframap.org/#4/46.68/-87.98/Water

What do you think ?

@jywarren
Copy link
Member

jywarren commented Jul 1, 2018 via email

@jywarren
Copy link
Member

jywarren commented Jul 1, 2018 via email

@sagarpreet-chadha
Copy link
Collaborator Author

Its part of https://www.openstreetmap.org .....hence data is crowdsourced .

By and large, this data isn't exposed on the main OSM map, so I built Open Infrastructure Map to visualise it.
Source : https://openinframap.org/about.html

@jywarren
Copy link
Member

jywarren commented Jul 1, 2018 via email

@jywarren
Copy link
Member

jywarren commented Jul 1, 2018 via email

@sagarpreet-chadha
Copy link
Collaborator Author

I was reading about EPA and it makes sense that we will not get any help from them .
I have searched for sites that mirror the data but couldn't find any that we can use .

Thanks ! Asking on Publiclab.org .

@jywarren
Copy link
Member

Hi, @sagarpreet-chadha there seems to be some code samples here for the first EPA dataset: https://www.epa.gov/waterdata/navigation-delineation-service for watersheds... take a look?

@jywarren
Copy link
Member

@sagarpreet-chadha
Copy link
Collaborator Author

Okay great ! Looking at the code samples 👍 .

@jywarren jywarren pinned this issue Mar 8, 2019
@jywarren jywarren unpinned this issue Mar 8, 2019
@jywarren
Copy link
Member

jywarren commented Mar 8, 2019

Closing in favor of #134

@jywarren jywarren closed this as completed Mar 8, 2019
sagarpreet-chadha pushed a commit that referenced this issue May 27, 2019
Update README with JS Coding Style Badge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants