Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement self service user password change #918

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jordy2254
Copy link
Member

Implements #263 base functionality to enable user to change their own password. This is a requirement for work intended to be done by me on #571 & #78.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 24.13793% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 25.15%. Comparing base (8cdc4cd) to head (9abd61e).
Report is 2 commits behind head on master.

Files Patch % Lines
api/graphql/resolvers/user.go 0.00% 18 Missing ⚠️
api/graphql/models/user.go 63.63% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #918       +/-   ##
===========================================
- Coverage   36.18%   25.15%   -11.03%     
===========================================
  Files          38       96       +58     
  Lines        1708     4428     +2720     
===========================================
+ Hits          618     1114      +496     
- Misses        934     3065     +2131     
- Partials      156      249       +93     
Flag Coverage Δ
api 25.15% <24.13%> (-11.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kkovaletp
Copy link
Contributor

Merged to #910 after basic testing locally

@kkovaletp
Copy link
Contributor

Hi @jordy2254, I've just got the feedback that not every user should have the possibility to change their own password: for instance, demo user shouldn't.

So, can you please do a small (I hope) update to this PR and implement a new switch per user on the Admin's settings page to allow or forbid self-change of the password?

This is now a crucial thing, which stops some users from using the latest build

@jordy2254
Copy link
Member Author

Hey @kkovaletp
Yeah i can try to take a look at it tomorrow unfortunately I have a bit of a busy week ahead though. I guess for the meantime we can either;

  • Give instructions to those on how to get back to the previous version
  • revert the change on your branch entirely and merge back in again when it's ready (You've said in the past you're not a dev so happy to assist with this if needed.).

In the meantime I'll reach out on the discord channel and talk through the wider scope of the change and the changes I have planned and in the process of making to see if we want to wait it out.

@kkovaletp
Copy link
Contributor

No need to revert the branch so far, also it is pretty clear how to revert to a previous commit locally and build from it for users, who reported this issue. So, we can wait for your update on the PR.

Sure, it is completely clear that you have your own plans, busy and free time. No need to rush and urgently develop an update! My request is just to update your list of prioritized tasks for our project, so that the next time, you'll work on it, you can start from this task and then continue your development of other features.

@jordy2254 jordy2254 added feature A new idea or feature API Related to the backend api server written in Go UI Related to the frontend web ui written in Javascript labels Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Related to the backend api server written in Go feature A new idea or feature UI Related to the frontend web ui written in Javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants