New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement self service user password change #918
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #918 +/- ##
===========================================
- Coverage 36.18% 25.15% -11.03%
===========================================
Files 38 96 +58
Lines 1708 4428 +2720
===========================================
+ Hits 618 1114 +496
- Misses 934 3065 +2131
- Partials 156 249 +93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged to #910 after basic testing locally |
Hi @jordy2254, I've just got the feedback that not every user should have the possibility to change their own password: for instance, demo user shouldn't. So, can you please do a small (I hope) update to this PR and implement a new switch per user on the Admin's settings page to allow or forbid self-change of the password? This is now a crucial thing, which stops some users from using the latest build |
Hey @kkovaletp
In the meantime I'll reach out on the discord channel and talk through the wider scope of the change and the changes I have planned and in the process of making to see if we want to wait it out. |
No need to revert the branch so far, also it is pretty clear how to revert to a previous commit locally and build from it for users, who reported this issue. So, we can wait for your update on the PR. Sure, it is completely clear that you have your own plans, busy and free time. No need to rush and urgently develop an update! My request is just to update your list of prioritized tasks for our project, so that the next time, you'll work on it, you can start from this task and then continue your development of other features. |
Implements #263 base functionality to enable user to change their own password. This is a requirement for work intended to be done by me on #571 & #78.